Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update magic-string #6711

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

AriPerkkio
Copy link
Member

Description

Updates magic-string and updates snapshots of coverage tests. The change in magic-string seems to affect some of our edge case tests of coverage. I don't think end-users will see changes in their reports.

  • Coverage of *.custom language that uses magic-string in its Vite Plugin:
    • /**
      * Plugin for transforming `.custom-1` and/or `.custom-2` files to Javascript
      */
      function customFilePlugin(postfix: "1" | "2"): Plugin {
      function transform(code: MagicString) {
      code.replaceAll(
      "<function covered>",
      `
      function covered() {
      return "Custom-${postfix} file loaded!"
      }
      `.trim()
      );
    • Some empty lines are now excluded, nothing to worry about:
  • Coverage of pre-bundled sources. Similar empty line exclusion happens here now:

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Oct 15, 2024

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 3799a4d
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/670e33b33c55100008d9d0e1
😎 Deploy Preview https://deploy-preview-6711--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

sheremet-va
sheremet-va previously approved these changes Oct 15, 2024
@sheremet-va
Copy link
Member

Can you resolve the conflict?

@AriPerkkio AriPerkkio force-pushed the chore/magic-string-update branch from e55601d to 3799a4d Compare October 15, 2024 09:19
@sheremet-va sheremet-va merged commit 62ac4eb into vitest-dev:main Oct 15, 2024
17 checks passed
@AriPerkkio AriPerkkio deleted the chore/magic-string-update branch October 15, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants