type: date format is not formatted correctly in c#

[danzel]

When a "type": "date" property is present in a schema we can generate a DateTime or DateTimeOffset field.
However, when when serializing this field it is not turned in to a date, it is turned in to a dateTime.

ref: https://swagger.io/specification/#document-structure-12
date should be a full-date, which is yyyy-MM-dd in c#.

To fix this, you can add [Newtonsoft.Json.JsonConverter(typeof(DateFormatConverter))] to the Property and define that converter as:

	public class DateFormatConverter : Newtonsoft.Json.Converters.IsoDateTimeConverter
	{
		public DateFormatConverter()
		{
			DateTimeFormat = "yyyy-MM-dd";
		}
	}

Trying to figure out how to fix this myself, but... there is a lot of code in here :)

[danzel]

Figured out the typescript version, but I'm not sure how to implement it for c#, some help or advice here would be greatly appreciated. Thanks!

[RicoSuter]

I dont like to add more helper classes to the output (i.e. DateFormatConverter) but it seems that this is the only solution. The question is whether we generate this as a global type (potential name collisions) or as inline time in each class (more code, repetitions).

[danzel]

We may need to do it in each class, otherwise if they generate multiple clients in the same project we’ll cause a collision :(

…

On Mon, 2 Oct 2017 at 6:45 PM, Rico Suter ***@***.***> wrote: I dont like to add more helper classes to the output (i.e. DateFormatConverter) but it seems that this is the only solution. The question is whether we generate this as a global type (potential name collisions) or as inline time in each class (more code, repetitions). — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#491 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAX_ftfKBtq_OaVeK-an-IFr7yqNcbzcks5soHhfgaJpZM4PqJ7M> .

[RicoSuter]

Yes, this is exactly the problem (I think its a rare case, because it only happens when generating multiple clients from multiple swagger specs).

I still prefer the "single utility class" option because we already have this problem with the JsonInheritanceConverter. However we should add the option GenerateDateFormatConverter (default: true) so that you can disable the generation for all but one generation (we also have GenerateJsonInheritanceConverter).

This way it works the same for all these utility classes.

What do you think?

[danzel]

Ah yeah, that seems like a good way to do it.
I'll try take a look at this one tomorrow.

(Reminder to self: NJsonSchema.CodeGeneration.CSharp/Templates/ClassTemplate.tt)

[RicoSuter]

The actual class is rendered in FileTemplate.tt