Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support 'date' format properties in the CSharp Generator #496

Merged
merged 5 commits into from
Oct 3, 2017
Merged

Support 'date' format properties in the CSharp Generator #496

merged 5 commits into from
Oct 3, 2017

Conversation

danzel
Copy link
Contributor

@danzel danzel commented Oct 3, 2017

Fixes #491

Like #493, but for csharp :)

@RicoSuter
Copy link
Owner

Thank you - looks good! Just made some minor adjustments:

  • Made DateFormatConverterTemplateModel public: Will be public in API when we have a new template engine, what do you think? => Epic: Replace template engine NSwag#263
  • Use JsonFormatStrings.Date instead of "date"

@RicoSuter RicoSuter merged commit 79af592 into RicoSuter:master Oct 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danzel @RicoSuter