Merge pull request #268 from Roave/handle-function-reflection-filenam…

…e-false Ensure locateFunctionByName returns ?string always
Roave · Apr 18, 2017 · a95cb4e · a95cb4e
2 parents ef87705 + dcf2d0a
commit a95cb4e
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/src/SourceLocator/Type/AutoloadSourceLocator.php b/src/SourceLocator/Type/AutoloadSourceLocator.php
@@ -45,6 +45,7 @@ protected function createLocatedSource(Identifier $identifier) : ?LocatedSource
      *
      * @param Identifier $identifier
      * @return string|null
+     * @throws \ReflectionException
      */
     private function attemptAutoloadForIdentifier(Identifier $identifier) : ?string
     {
@@ -74,6 +75,7 @@ private function attemptAutoloadForIdentifier(Identifier $identifier) : ?string
      *
      * @param string $className
      * @return string|null
+     * @throws \ReflectionException
      */
     private function locateClassByName(string $className)  : ?string
     {
@@ -105,6 +107,7 @@ class_exists($className);
      *
      * @param string $functionName
      * @return string|null
+     * @throws \ReflectionException
      */
     private function locateFunctionByName(string $functionName) : ?string
     {
@@ -113,7 +116,13 @@ private function locateFunctionByName(string $functionName) : ?string
         }
 
         $reflection = new \ReflectionFunction($functionName);
-        return $reflection->getFileName();
+        $reflectionFileName = $reflection->getFileName();
+
+        if (! is_string($reflectionFileName)) {
+            return null;
+        }
+
+        return $reflectionFileName;
     }
 
     /**

diff --git a/test/unit/SourceLocator/Type/AutoloadSourceLocatorTest.php b/test/unit/SourceLocator/Type/AutoloadSourceLocatorTest.php
@@ -177,4 +177,15 @@ public function testShouldNotConsiderEvaledSources() : void
                 ->locateIdentifier($this->getMockReflector(), new Identifier($className, new IdentifierType(IdentifierType::IDENTIFIER_CLASS)))
         );
     }
+
+    public function testReturnsNullWithInternalFunctions() : void
+    {
+        self::assertNull(
+            (new AutoloadSourceLocator())
+                ->locateIdentifier(
+                    $this->getMockReflector(),
+                    new Identifier('strlen', new IdentifierType(IdentifierType::IDENTIFIER_FUNCTION))
+                )
+        );
+    }
 }