Ensure locateFunctionByName returns ?string always #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asgrim
force-pushed
the
handle-function-reflection-filename-false
branch
from
5c570c8 to
56bd5b1
Compare
Ocramius
requested changes
Apr 18, 2017
| return $reflection->getFileName(); | ||
| $reflectionFileName = $reflection->getFileName(); | ||
|
|
||
| if (! is_string($reflectionFileName)) { |
Ocramius
approved these changes
Apr 18, 2017
|
🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #237
Now that we have strict type declarations, I don't think an additional test is necessary - this is essentially a bugfix now IMO...