Fixes for sleep mode / health mode activation / RFC for 8℃ Heating mode #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PLTorrent
changed the title
PLTorrent
changed the title
RobHofmann
approved these changes
Jan 7, 2020
|
You're welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed sleep mode operation:
This is a solution to #44
Fix Health function activation:
Currently it is only possible to operate health function in cool and dry mode. This is not a limitation of the device as health function (cold plasma caster) is not dependent on the mode of operation and can be activated/deactivated in every mode. Therefore I propose a change that allows that.
RFC - 8 deg C Heat function
This is implementation of RFC #46.
The input_boolean is working, mode is limited only to Heat as on real AC.
The only thing missing is that when this mode is activated it would be good to display target temp as 8 deg C the same as on the device display. Maybe someone could add this or give me a hint how to do it quickly. Didn't want to mess up the temp refreshing/setting.