Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(project): Removed UnicodeExpr as it is no longer supported #526

Merged
merged 1 commit into from
Oct 23, 2022

Conversation

rhoboro
Copy link
Contributor

@rhoboro rhoboro commented Oct 23, 2022

Change Summary

mypy command gives the following error and I found python/mypy#13254 and python/mypy#12237 .
So, I removed it.

Screen Shot 2022-10-23 at 14 31 21

Checklist

  • Unit tests for the changes exist
  • Tests pass without significant drop in coverage
  • Documentation reflects changes where applicable
  • Test snapshots have been updated if applicable

Agreement

By submitting this pull request, I confirm that you can use, modify, copy and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Oct 23, 2022

Codecov Report

Base: 94.33% // Head: 94.33% // No change to project coverage 👍

Coverage data is based on head (2882dba) compared to base (c081b9b).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #526   +/-   ##
=======================================
  Coverage   94.33%   94.33%           
=======================================
  Files         120      120           
  Lines        6073     6073           
  Branches     1039      995   -44     
=======================================
  Hits         5729     5729           
  Misses        301      301           
  Partials       43       43           
Impacted Files Coverage Δ
src/prisma/mypy.py 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@RobertCraigie
Copy link
Owner

Thanks for fixing this!

It looks like UnicodeExpr was actually only used for Python 2 which I had not realised when originally writing the mypy plugin.

@RobertCraigie RobertCraigie merged commit 0a14eb5 into RobertCraigie:main Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants