Delete Python 2 specific AST nodes #13254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
1 similar comment
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
| # b'x', 'x' -> StrExpr | ||
| # u'x' -> UnicodeExpr | ||
| # BytesExpr is unused | ||
| # How mypy uses StrExpr and BytesExpr: |
There was a problem hiding this comment.
We could even remove this whole comment, in Python 3 it's pretty self-explanatory.
JelleZijlstra
approved these changes
Jul 28, 2022
| @@ -339,15 +338,13 @@ def parse_namedtuple_args( | |||
| if call.arg_kinds[:2] != [ARG_POS, ARG_POS]: | |||
| self.fail(f'Unexpected arguments to "{type_name}()"', call) | |||
| return None | |||
| if not isinstance(args[0], (StrExpr, BytesExpr, UnicodeExpr)): | |||
| if not isinstance(args[0], (StrExpr, BytesExpr)): | |||
There was a problem hiding this comment.
Interesting that we allow bytes names here, but no need to change that in this PR.
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #12237
This includes
UnicodeExpr,BackquoteExpr,PrintStmt, andExecStmt.