[sensors] Launch vectornav in bringup.launch.py
#229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidcalderon03
requested changes
Nov 1, 2024
yambati03
requested changes
Nov 3, 2024
There was a problem hiding this comment.
The changes to bringup.launch.py look good, but had a few comments about the other checked in code. Also, we'll likely want a way to quickly zero the IMU (not sure if the vectornav already comes with a service to do this). I'd also add some instructions for calibrating the IMU and setting the correct magnetic declination.
urc_localization/src/ned_to_enu.cpp
Outdated
There was a problem hiding this comment.
Is this file supposed to be here? It is empty.
urc_platform/src/imu_parser.cpp
Outdated
There was a problem hiding this comment.
I don't think we need this IMU parser node anymore. There should be an option in the config file for the vectornav package that will automatically publish a ROS 2 sensor_msgs/Imu message.
yambati03
changed the title
vectornav in bringup.launch.py
yambati03
changed the title
vectornav in bringup.launch.pyvectornav in bringup.launch.py
Signed-off-by: David Calderon <davidcalderon03@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR does the following: