Generate charts with data filtered by selected currency #1602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
femelo
force-pushed
the
674-market-price-and-depth-based-on-selected-currency
branch
from
e85a292 to
5f9683c
Compare
Pre-commit changes
femelo
force-pushed
the
674-market-price-and-depth-based-on-selected-currency
branch
from
5f9683c to
e61db29
Compare
|
great improvement! thanks! I just detected a little issue. When you change from USD back to ANY, the chart doesn't refresh:
Weirdly enough, this only fails for USD 🙃 |
Good catch! Could you please check again? |
femelo
force-pushed
the
674-market-price-and-depth-based-on-selected-currency
branch
from
3e7336e to
a5545ef
Compare
|
Looks good! Merging as is! Please submit a 10K Sats invoice for a small DevFund tip. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #674
This PR modifies DepthChart to show charts based only on the selected currency.
Checklist before merging
pip install pre-commit, thenpre-commit install. Pre-commit installs git hooks that automatically check the codebase. If pre-commit fails when you commit your changes, please fix the problems it points out.