Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate charts with data filtered by selected currency #1602

Merged
merged 2 commits into from
Nov 24, 2024
Merged

Generate charts with data filtered by selected currency #1602

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e61db29
Generate charts with data filtered by selected currency
femelo Nov 6, 2024
a5545ef
Bugfix: refresh chart when USD is selected
femelo Nov 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 20 additions & 8 deletions frontend/src/components/Charts/DepthChart/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,14 +55,14 @@ const DepthChart: React.FC<DepthChartProps> = ({
const [rangeSteps, setRangeSteps] = useState<number>(8);
const [xRange, setXRange] = useState<number>(8);
const [xType, setXType] = useState<string>('premium');
const [currencyCode, setCurrencyCode] = useState<number>(1);
const [currencyCode, setCurrencyCode] = useState<number>(0);
const [center, setCenter] = useState<number>();

const height = maxHeight < 10 ? 10 : maxHeight;
const width = maxWidth < 10 ? 10 : maxWidth > 72.8 ? 72.8 : maxWidth;

useEffect(() => {
setCurrencyCode(fav.currency === 0 ? 1 : fav.currency);
setCurrencyCode(fav.currency); // as selected in BookControl
}, [fav.currency]);

useEffect(() => {
Expand All @@ -74,7 +74,7 @@ const DepthChart: React.FC<DepthChartProps> = ({
const originalPrice =
(limits[order.currency]?.price ?? 0) * (1 + parseFloat(order.premium) / 100);
const currencyPrice =
(limits[currencyCode]?.price ?? 0) * (1 + parseFloat(order.premium) / 100);
(limits[currencyCode || 1]?.price ?? 0) * (1 + parseFloat(order.premium) / 100);

const originalAmount =
order.has_range && order.max_amount
Expand Down Expand Up @@ -124,10 +124,22 @@ const DepthChart: React.FC<DepthChartProps> = ({
const generateSeries: () => void = () => {
const sortedOrders: PublicOrder[] =
xType === 'base_price'
? enrichedOrders.sort(
(order1, order2) => (order1?.base_price ?? 0) - (order2?.base_price ?? 0),
)
: enrichedOrders.sort((order1, order2) => order1?.premium - order2?.premium);
? enrichedOrders
.filter(
(order: PublicOrder | null) => currencyCode === 0 || order?.currency == currencyCode,
)
.sort(
(order1: PublicOrder | null, order2: PublicOrder | null) =>
(order1?.base_price ?? 0) - (order2?.base_price ?? 0),
)
: enrichedOrders
.filter(
(order: PublicOrder | null) => currencyCode === 0 || order?.currency == currencyCode,
)
.sort(
(order1: PublicOrder | null, order2: PublicOrder | null) =>
order1?.premium - order2?.premium,
);

const sortedBuyOrders: PublicOrder[] = sortedOrders
.filter((order) => order?.type === 0)
Expand Down Expand Up @@ -317,7 +329,7 @@ const DepthChart: React.FC<DepthChartProps> = ({
<Grid item>
<Box justifyContent='center'>
{xType === 'base_price'
? `${center} ${String(currencyDict[currencyCode])}`
? `${center} ${String(currencyDict[(currencyCode || 1) as keyof object])}`
: `${String(center.toPrecision(3))}%`}
</Box>
</Grid>
Expand Down