Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drake's WORKSPACE uses new_local_repository with relative paths #7261

Closed
jwnimmer-tri opened this issue Oct 14, 2017 · 0 comments · Fixed by #7361
Closed

Drake's WORKSPACE uses new_local_repository with relative paths #7261

jwnimmer-tri opened this issue Oct 14, 2017 · 0 comments · Fixed by #7361

Comments

@jwnimmer-tri
Copy link
Collaborator

As discovered by @stonier, per the Bazel docs on new_local_repository, the path argument "must be an absolute path to an existing file or a directory". Drake's //:WORKSPACE has several cases where it uses relative paths into the Drake tree. This currently works fine, but may stop working in the future because it is contrary to the docs. Possibly the needs of #7259 will also demand a different approach.

In any case, we should figure out whether Bazel's code or the docs is correct, and then adjust (or document) our //:WORKSPACE to match that understanding. If indeed its forbidden, then I think we can write our own version of the macro that works in a workspace-relative way. If its supported, then we should document that caveat to prevent future confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant