unique_ptr: Fix ownership issues for failed overloads (RobotLocomotion/drake#8160) #11
+49
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricCousineau-TRI
changed the title
EricCousineau-TRI
force-pushed
the
issue/drake_8160
branch
from
f8ca528 to
6eb3cd8
Compare
|
@basicNew @apojomovsky I've submitted the fix for this, and have sent y'all an invite as collaborators for this repo (for review). Could one of y'all do review for this PR? (just a high-level overview - looking at the changes, and ensure that this actually captures the root issue for RobotLocomotion/drake#8160) NOTE: This fork has broken support on Windows (AppVeyor), so those tests will fail. I have deferred fixing those until it becomes important for this fork (either it'll be upstreamed, or someone wants Windows support). |
EricCousineau-TRI
changed the title
EricCousineau-TRI
force-pushed
the
issue/drake_8160
branch
from
6eb3cd8 to
afe5ed3
Compare
EricCousineau-TRI
added a commit
to EricCousineau-TRI/drake
that referenced
this pull request
Feb 23, 2018
…d transactions)
1 task
EricCousineau-TRI
force-pushed
the
issue/drake_8160
branch
from
afe5ed3 to
b43f2b1
Compare
EricCousineau-TRI
force-pushed
the
issue/drake_8160
branch
from
b43f2b1 to
fe60760
Compare
|
Review status: 0 of 3 files reviewed at latest revision, all discussions resolved, some commit checks failed. Comments from Reviewable |
|
Reviewed 2 of 2 files at r1, 1 of 1 files at r3. Comments from Reviewable |
EricCousineau-TRI
added a commit
to EricCousineau-TRI/drake
that referenced
this pull request
Feb 26, 2018
…d transactions)
This was referenced Feb 26, 2018
EricCousineau-TRI
added a commit
to RobotLocomotion/drake
that referenced
this pull request
Feb 26, 2018
pybind11: Incorporate RobotLocomotion/pybind11#11 (unique_ptr overload transactions)
This was referenced Mar 12, 2018
jwnimmer-tri
pushed a commit
to jwnimmer-tri/pybind11
that referenced
this pull request
Dec 24, 2024
* Support free-threaded CPython (PEP 703) Some additional locking is added in the free-threaded build when `Py_GIL_DISABLED` is defined: - Most accesses to internals are protected by a single mutex - The registered_instances uses a striped lock to improve concurrency Pybind11 modules can indicate support for running with the GIL disabled by calling `set_gil_not_used()`. * refactor: use PYBIND11_MODULE (RobotLocomotion#11) Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com> * Address code review * Suppress MSVC warning * Changes from review * style: pre-commit fixes * `py::mod_gil_not_used()` suggestion. * Update include/pybind11/pybind11.h --------- Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com> Co-authored-by: Henry Schreiner <HenrySchreinerIII@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Ralf W. Grosse-Kunstleve <rwgk@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is