Urdf: add method unsubscribeTf #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -118,3 +118,7 @@ ROS3D.Urdf = function(options) { | |||
| } | |||
| }; | |||
| ROS3D.Urdf.prototype.__proto__ = THREE.Object3D.prototype; | |||
|
|
|||
| ROS3D.Urdf.prototype.unsubscribeTf = function () { | |||
| this.children.forEach(function(n) { n.unsubscribeTf(); }); | |||
There was a problem hiding this comment.
You may want to validate that the child objects are infact SceneNodes or atleast has the unsubscribeTf function before calling a potentially undefined method as any custom component attached to the Object3D would be returned here.
|
lgtm, thanks for reviewing, @sevenbitbyte ! |
|
Merged without grunt build.. Maybe add this check to your Travis CI job or make it a pre-commit hook? |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a method to unsubscribe tf updates for all frames of the URDF's links.