Fix unused variables: flake8 --select=F841 #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
force-pushed
the
unused-variables
branch
2 times, most recently
from
82030fe to
fe3dfdb
Compare
3 tasks
cclauss
force-pushed
the
unused-variables
branch
from
fe3dfdb to
92b7e37
Compare
amacneil
reviewed
Oct 7, 2021
| @@ -77,7 +77,7 @@ def fragment(self, message, fragment_size, mid=None): | |||
| if message_length <= fragment_size: | |||
| return [message] | |||
|
|
|||
| msg_id = message.get("id", None) | |||
There was a problem hiding this comment.
I suggest just deleting this line entirely
amacneil
reviewed
Oct 7, 2021
| @@ -70,7 +70,7 @@ def stopProtocol(self): | |||
| rospy.loginfo("Client disconnected. %d clients total.", cls.clients_connected) | |||
|
|
|||
| def send_message(self, message): | |||
| binary = isinstance(message, bson.BSON) | |||
cclauss
force-pushed
the
unused-variables
branch
from
d8e3765 to
ea58349
Compare
amacneil
reviewed
Oct 7, 2021
| @@ -35,7 +35,7 @@ | |||
|
|
|||
| def calculate_service_response(request): | |||
| request_object = json.loads(request) # parse string for service request | |||
| args = request_object["args"] # get parameter field (args) | |||
There was a problem hiding this comment.
I think since this is a test this whole block of commented code (line 38-45) seems to be dead, we can delete it
There was a problem hiding this comment.
actually, maybe leave it there. I'm not sure if the test is being used. someone has been making PRs to fix these tests so maybe it is helpful for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
five of thesix flake8 issues related to variables that are assigned to but then not used.This PR does not fix the following issue where theNOTE: Fixed in second commit.--unregister_timeoutcommand line option should probably be removed,