Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update exception for rosservice_find #184

Closed
wants to merge 1 commit into from

Conversation

dwlee
Copy link
Contributor

@dwlee dwlee commented Jun 11, 2015

rosservice_find function raises ROSServiceIOException error when it has communication error with master.

http://docs.ros.org/jade/api/rosservice/html/rosservice-pysrc.html#rosservice_find

@ablakey
Copy link
Contributor

ablakey commented Jun 11, 2015

Is raising an ROSServiceIOException not ideal? What's the case you're running into where you want it to essentially pass on this error?

@dwlee
Copy link
Contributor Author

dwlee commented Jun 11, 2015

I think ROSServiceIOException error is handled by application side not rosbridge level.
So, I closed this PR and will follow up at RobotWebTools/roslibjs#180

@dwlee dwlee closed this Jun 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants