Implementing license header checking in CI #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, Thank you! I don't think this is mentioned in the readmes, we use pre-commit for code formatting. Please run the following: pre-commit run -a |
|
Thank you for this contribution! |
john-science
force-pushed
the
licence_checker_ci
branch
from
f1cc435 to
e045463
Compare
Oh, sorry about that. Okay, I ran |
Thanks to @adamdbrw for the correction; I was only looking at the Python code. Co-authored-by: Adam Dąbrowski <adam.dabrowski@robotec.ai>
maciejmajek
reviewed
Sep 3, 2024
Okay, linter came back clean. |
maciejmajek
pushed a commit
that referenced
this pull request
Sep 18, 2024
Co-authored-by: Adam Dąbrowski <adam.dabrowski@robotec.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Proposed Changes
What does this PR add, remove or fix?
I have added one GitHub Action CI (to check that every Python file has a Copyright header at the top). And I had to add one metadata file to the root of the repo, to make this CI action run properly.
Issues
Testing
This is it's own CI, so it is self-testing. After running it the first time, I found three
__init__.pyfiles that were lacking the header. Kind of an oddity, but looking around at some other open-source projects that have this license header rule (e.g. armi, this appears to be the standard, so I went with it.