Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update poetry dependencies (pydantic v2) #228

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 16, 2024

Merge after #143

Update poetry dependencies to use latest compatible versions.

Poetry update message:
Updating dependencies
Resolving dependencies...

Package operations: 3 installs, 31 updates, 0 removals

  • Updating idna (3.8 -> 3.10)
  • Updating pydantic-core (2.23.2 -> 2.23.3)
  • Updating urllib3 (2.2.2 -> 2.2.3)
  • Updating pydantic (2.9.0 -> 2.9.1)
  • Updating langsmith (0.1.116 -> 0.1.120)
  • Updating multidict (6.0.5 -> 6.1.0)
  • Updating greenlet (3.0.3 -> 3.1.0)
  • Updating langchain-core (0.2.38 -> 0.3.0)
  • Updating platformdirs (4.3.2 -> 4.3.3)
  • Updating yarl (1.11.0 -> 1.11.1)
  • Downgrading fsspec (2024.9.0 -> 2024.6.1)
  • Updating langchain-text-splitters (0.2.4 -> 0.3.0)
  • Updating protobuf (5.28.0 -> 5.28.1)
  • Installing python-dotenv (1.0.1)
  • Updating pytz (2024.1 -> 2024.2)
  • Updating narwhals (1.6.3 -> 1.8.1)
  • Updating regex (2024.7.24 -> 2024.9.11)
  • Updating identify (2.6.0 -> 2.6.1)
  • Updating langchain (0.2.16 -> 0.3.0)
  • Installing langgraph-checkpoint (1.0.9)
  • Updating onnxruntime (1.19.0 -> 1.19.2)
  • Updating openai (1.44.0 -> 1.45.0)
  • Updating rich (13.8.0 -> 13.8.1)
  • Updating scikit-learn (1.5.1 -> 1.5.2)
  • Updating ollama (0.3.2 -> 0.3.3)
  • Installing pydantic-settings (2.5.2)
  • Updating elevenlabs (1.7.0 -> 1.8.1)
  • Updating langchain-aws (0.1.17 -> 0.2.0)
  • Updating langchain-community (0.2.16 -> 0.3.0)
  • Updating langchain-openai (0.1.23 -> 0.2.0)
  • Updating langchain-ollama (0.1.3 -> 0.2.0)
  • Updating langgraph (0.0.66 -> 0.2.21)
  • Updating langfuse (2.47.0 -> 2.48.1)
  • Updating pytest (8.3.2 -> 8.3.3)

Writing lock file

@maciejmajek maciejmajek reopened this Sep 16, 2024
@maciejmajek maciejmajek changed the title Update poetry dependencies chore: Update poetry dependencies (pydantic v2) Sep 16, 2024
@boczekbartek boczekbartek self-requested a review September 17, 2024 14:19
Copy link
Member

@boczekbartek boczekbartek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Output of pydantic error seem a bit too long in v2 version. I think there is some risk that LLM might be more prone to halucinating after such output. Argument checking errors should be very precise.

development

[INFO] [1726657449.847004486] [rai_node]: Args validation error in "Ros2RunAction", error: 1 validation error for Ros2ActionRunnerInput
action_goal_args
  field required (type=value_error.missing)

this PR

[INFO] [1726656158.805772776] [rai_node]: Args validation error in "Ros2RunAction", error: 1 validation error for Ros2ActionRunnerInput
action_goal_args
  Field required [type=missing, input_value={'action_name': '/spin', ...'nav2_msgs/action/Spin'}, input_type=dict]
    For further information visit https://errors.pydantic.dev/2.9/v/missing

How about trimming it? I think it's handled here:

except ValidationError as e:

Copy link
Member

@boczekbartek boczekbartek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maciejmajek maciejmajek merged commit acfde91 into development Sep 18, 2024
4 checks passed
@maciejmajek maciejmajek deleted the update/poetry-update branch September 18, 2024 14:36
maciejmajek added a commit that referenced this pull request Sep 18, 2024
Co-authored-by: Maciej Majek <maciej.majek@robotec.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants