-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update poetry dependencies (pydantic v2) #228
Conversation
45f6e13
to
73cf8cf
Compare
f96408a
to
e2dc116
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Output of pydantic error seem a bit too long in v2 version. I think there is some risk that LLM might be more prone to halucinating after such output. Argument checking errors should be very precise.
development
[INFO] [1726657449.847004486] [rai_node]: Args validation error in "Ros2RunAction", error: 1 validation error for Ros2ActionRunnerInput
action_goal_args
field required (type=value_error.missing)
this PR
[INFO] [1726656158.805772776] [rai_node]: Args validation error in "Ros2RunAction", error: 1 validation error for Ros2ActionRunnerInput
action_goal_args
Field required [type=missing, input_value={'action_name': '/spin', ...'nav2_msgs/action/Spin'}, input_type=dict]
For further information visit https://errors.pydantic.dev/2.9/v/missing
How about trimming it? I think it's handled here:
rai/src/rai/rai/agents/state_based.py
Line 161 in e2dc116
except ValidationError as e: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Maciej Majek <maciej.majek@robotec.ai>
Merge after #143
Update
poetry
dependencies to use latest compatible versions.Poetry update message:
Updating dependencies
Resolving dependencies...
Package operations: 3 installs, 31 updates, 0 removals
Writing lock file