Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Ros2PubMessageTool): not all messages has headers + unitest #237

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

boczekbartek
Copy link
Member

@boczekbartek boczekbartek commented Sep 24, 2024

Purpose

Fixes Ros2PubMsgTool and adds unittest

Proposed Changes

Skip setting header for messages that doesn't have header

Issues

Testing

pytest -m billable -s -k ros2_tools test

@boczekbartek boczekbartek marked this pull request as ready for review September 24, 2024 11:46
Copy link
Member

@maciejmajek maciejmajek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition. LGTM

@boczekbartek boczekbartek merged commit 6ea2533 into development Sep 26, 2024
4 checks passed
@boczekbartek boczekbartek deleted the fix/ros2_pub_msg_tool branch September 26, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants