Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove CI on draft PRs #244

Merged
merged 6 commits into from
Sep 26, 2024
Merged

Conversation

rachwalk
Copy link
Contributor

@rachwalk rachwalk commented Sep 25, 2024

Purpose

The purpose of a draft PR is to contain incomplete work, which may contain mistakes. Having CI build run on draft PRs is a waste of cloud computations.

Proposed Changes

removes CI on draft PRs

Issues

N/A

Testing

This PR was created as a draft, then it was opened as ready for review, to verify that checks are run in valid circumstance.

@rachwalk rachwalk marked this pull request as ready for review September 25, 2024 16:41
@rachwalk rachwalk marked this pull request as draft September 25, 2024 16:46
@rachwalk rachwalk marked this pull request as ready for review September 26, 2024 11:07
@maciejmajek maciejmajek marked this pull request as draft September 26, 2024 11:37
@maciejmajek maciejmajek force-pushed the kr/remove-ci-on-draft-prs branch from 76a29d7 to 67fb4a5 Compare September 26, 2024 11:52
@maciejmajek maciejmajek marked this pull request as ready for review September 26, 2024 11:52
Copy link
Member

@maciejmajek maciejmajek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't work
Also, please do not edit the poetry-update job.

@rachwalk rachwalk force-pushed the kr/remove-ci-on-draft-prs branch from 885058e to 355d60b Compare September 26, 2024 13:01
@rachwalk rachwalk marked this pull request as draft September 26, 2024 13:02
@rachwalk rachwalk marked this pull request as ready for review September 26, 2024 13:03
@rachwalk rachwalk marked this pull request as draft September 26, 2024 13:11
@rachwalk rachwalk force-pushed the kr/remove-ci-on-draft-prs branch from 1b9f029 to dc531dd Compare September 26, 2024 13:15
@maciejmajek maciejmajek marked this pull request as ready for review September 26, 2024 13:34
@maciejmajek maciejmajek marked this pull request as draft September 26, 2024 13:34
@maciejmajek maciejmajek marked this pull request as ready for review September 26, 2024 13:36
@maciejmajek maciejmajek self-requested a review September 26, 2024 13:44
@maciejmajek maciejmajek marked this pull request as draft September 26, 2024 13:44
@maciejmajek maciejmajek marked this pull request as ready for review September 26, 2024 13:44
Copy link
Member

@maciejmajek maciejmajek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maciejmajek maciejmajek merged commit 16fad8c into development Sep 26, 2024
6 checks passed
@maciejmajek maciejmajek deleted the kr/remove-ci-on-draft-prs branch September 26, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants