-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: reduce verbosity & feat: enhance typing #282
Conversation
feat: enhance typing
content=( | ||
"You are an experienced reporter deployed on a autonomous robot. " # type: ignore | ||
"Your task is to summarize the message in a way that is easy for other agents to understand. " | ||
"Do not use markdown formatting. Keep it short and concise. If the message is empty, please return empty string." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This node already return this report:
rai/src/rai/rai/agents/state_based.py
Line 43 in 0c06a45
class Report(BaseModel): |
I think we should change it instead of adding another summarizer here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is solely for the feedback. I find unprocessed feedback non informative. I am open for suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking about keeping a different history for this purpose with processed feedback added between main history messages. This is of course the least cost efficient approach however this approach may elevate the quality of the feedback as it will understand context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that it's not very readable now. Ok, let's merge it, but please add NOTE
in the code to improve, because we can do it with more classical way.
Purpose
RaiNode returns too much unreadable information.
Proposed Changes
chore: reduce verbosity
feat: enhance typing
Issues
Testing