Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reduce verbosity & feat: enhance typing #282

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

maciejmajek
Copy link
Member

Purpose

RaiNode returns too much unreadable information.

Proposed Changes

chore: reduce verbosity
feat: enhance typing

Issues

  • Links to relevant issues

Testing

  • How was it tested, what were the results?

feat: enhance typing
Comment on lines +507 to +510
content=(
"You are an experienced reporter deployed on a autonomous robot. " # type: ignore
"Your task is to summarize the message in a way that is easy for other agents to understand. "
"Do not use markdown formatting. Keep it short and concise. If the message is empty, please return empty string."
Copy link
Member

@boczekbartek boczekbartek Oct 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This node already return this report:

class Report(BaseModel):

I think we should change it instead of adding another summarizer here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is solely for the feedback. I find unprocessed feedback non informative. I am open for suggestions

Copy link
Member Author

@maciejmajek maciejmajek Oct 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking about keeping a different history for this purpose with processed feedback added between main history messages. This is of course the least cost efficient approach however this approach may elevate the quality of the feedback as it will understand context.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that it's not very readable now. Ok, let's merge it, but please add NOTE in the code to improve, because we can do it with more classical way.

@boczekbartek boczekbartek self-requested a review October 17, 2024 20:00
@maciejmajek maciejmajek merged commit 7b789bb into development Oct 18, 2024
4 checks passed
@maciejmajek maciejmajek deleted the chore/reduce-verbosity branch October 18, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants