Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turning ROS2-For-Unity into a package #94

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

RobertoRoos
Copy link

Relating to #86 . It doesn't seem nice ROS2ForUnity is locked into the Assets/ directory, when for all intends and purposes it is a package. So I'd suggest we make it installable as an actual package.

The most significant addition is just a package.json file.

@Deric-W
Copy link
Contributor

Deric-W commented Nov 29, 2023

Hi, I had a similar idea which I implemented in my fork but with some changes:

  • since packages can contain dedicated examples I moved the current examples
  • make Unity take care of packaging the metadata xml by putting it in a Resources directory
  • make Unity take care initializing the PATH and checking the Ros Version using RuntimeInitializeOnLoadMethod

If you want to implement some of these changes too I can rebase them on the current upstream since currently they are in a private repository together with other changes.

@RobertoRoos
Copy link
Author

Sounds great @Deric-W ! I would suggest to make your own PR and we can probably drop mine. I didn't make any changes on purpose besides just getting the packaging stuff to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants