Skip to content
This repository has been archived by the owner on Jun 7, 2020. It is now read-only.

[WIP][NEW] React to "Share" (ACTION_SEND) intent from another app #2264

Closed
wants to merge 18 commits into from

Conversation

Adizbek
Copy link
Contributor

@Adizbek Adizbek commented Apr 26, 2019

@RocketChat/android

Closes #98

Screenshots or GIF for the change:

https://youtu.be/OsXs4rdySFU

Adizbek added 8 commits April 7, 2019 16:23
# Conflicts:
#	app/src/main/java/chat/rocket/android/chatroom/ui/ChatRoomFragment.kt
#	app/src/main/java/chat/rocket/android/chatrooms/presentation/ChatRoomsPresenter.kt
#	app/src/main/java/chat/rocket/android/chatrooms/ui/ChatRoomsFragment.kt
#	app/src/main/java/chat/rocket/android/main/ui/MainActivity.kt
@Adizbek
Copy link
Contributor Author

Adizbek commented Apr 26, 2019

I have not finished yet.

@philipbrito
Copy link
Contributor

philipbrito commented Apr 26, 2019

@Adizbek In that case, just add a [WIP] on the PR's title to keeps us informed that it isn't ready to be merged yet.

Thanks for sending it!

@philipbrito philipbrito changed the title [NEW] React to "Share" (ACTION_SEND) intent from another app [WIP][NEW] React to "Share" (ACTION_SEND) intent from another app Apr 26, 2019
@philipbrito
Copy link
Contributor

@Adizbek Is it still a WIP?

@Adizbek
Copy link
Contributor Author

Adizbek commented May 14, 2019

@filipedelimabrito Not yet. I let you know when I finish. I have to test it fully.

@philipbrito
Copy link
Contributor

Just ping me when it is done and/or remove the [WIP] from the title.
Thank you very much.

@martinszy
Copy link

Hey, just to encourage you to finish this feature. It's been in the pipeline for three years now and it's one of the main things holding a part of my team from moving to free software messaging.
Thanks for your work :)

@Adizbek
Copy link
Contributor Author

Adizbek commented May 23, 2019

Thanks, I will finish I soon as I finish my final exams, they are sticking for now 😅

@philipbrito philipbrito added this to the 3.5.0 milestone Jun 3, 2019
@philipbrito
Copy link
Contributor

@Adizbek Will you be able to work on it?

@bizzbyster
Copy link
Contributor

@Adizbek any luck on this? Let me know if you need any help and perhaps we can find someone to finish this up.

@Adizbek
Copy link
Contributor Author

Adizbek commented Jul 7, 2019

Hello, I apologise, I was on vacation, I will continue this PR.

@philipbrito
Copy link
Contributor

Thanks for letting us know @Adizbek! Just ping me here when you think it is done.
Hope you are having a great vacation!

@leonn
Copy link

leonn commented Oct 15, 2019

Hey, @Adizbek if you don't mind, I have done the same thing with some improvements, as there are many people wanting & waiting for this behavior to be available, can I submit a PR to address this ?

@andrew-thought
Copy link

Would like to see this feature, very important

@andrew-thought
Copy link

Hey, @Adizbek if you don't mind, I have done the same thing with some improvements, as there are many people wanting & waiting for this behavior to be available, can I submit a PR to address this ?

I'm very interested leonn, thanks!

@Adizbek
Copy link
Contributor Author

Adizbek commented Oct 19, 2019

@leonn, of course, I had no time to finish it. It would be great if you have complete this feature, as many people waiting for it.

@Adizbek Adizbek closed this Oct 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NEW] React to "Share" (ACTION_SEND) intent from another app
6 participants