This repository has been archived by the owner on Jun 7, 2020. It is now read-only.
[NEW][RFC] Support receiving shared content (audio/video/text) #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luciofm
suggested changes
Apr 2, 2018
| when (it) { | ||
| is String -> putString(ARGUMENT_SHARED_CONTENT, it) | ||
| is Uri -> putParcelable(ARGUMENT_SHARED_CONTENT, it) | ||
| is ArrayList<*> -> if (it.size > 0 && it[0] is Uri) { |
| @@ -174,6 +188,14 @@ class ChatRoomFragment : Fragment(), ChatRoomView, EmojiKeyboardPopup.Listener { | |||
| if (oldMessagesCount == 0 && dataSet.isNotEmpty()) { | |||
| recycler_view.scrollToPosition(0) | |||
| } | |||
| contentToShare?.let { | |||
There was a problem hiding this comment.
Don't know if this is the right place to "plug" this...
Setting contentToShare as null seems like a code smell
There was a problem hiding this comment.
I know you are waiting the message list to be populated, but maybe we need a new callback on the View, to indicate the first messages are loaded.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/android
Closes #98