Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read receipts not working #15484

Closed
phriedrich opened this issue Oct 2, 2019 · 23 comments · Fixed by #15603
Closed

Read receipts not working #15484

phriedrich opened this issue Oct 2, 2019 · 23 comments · Fixed by #15603
Assignees

Comments

@phriedrich
Copy link

Description:

After updating to 2.1.0 the read receipts are not displayed anymore. No checkmark in browser, and only grey checkmarks in the app. No blue checkmarks after a message is read.

Also when showing message info, only the person who send the message is shown in the list.

Steps to reproduce:

  1. Direct chat or group chat
  2. open message context menu, select info
  3. only the person who wrote the message is shown, no one else, even if the message has been read

Expected behavior:

  • message read receipt shown in info
  • blue checkmark in direct chat

Actual behavior:

  • In group chats: only the person who wrote the message is shown, no one else, even if the message has been read
  • in direct chats no blue checkmark appears

Server Setup Information:

  • Version of Rocket.Chat Server: 2.1.0
  • Operating System: 4.19.72-gentoo, Ubuntu 18.04 LTE (tested on two systems)
  • Deployment Method: Docker
  • Number of Running Instances: 1
  • DB Replicaset Oplog: Enabled
  • NodeJS Version: v8.15.1
  • MongoDB Version: 4.2.0

Additional context

Relevant logs:

Server log when accessing "info":

Meteor ➔ method getReadReceipts -> userId: RQySce2mbjTpGyxGt , arguments:  [ { messageId: '4cce12f2-60f4-443f-b253-46043a799eae' } ]
Meteor ➔ method canAccessRoom -> userId: RQySce2mbjTpGyxGt , arguments:  [ 'THG8ez3NKvCi9WoYv', 'RQySce2mbjTpGyxGt' ]
@robopossum
Copy link

I am also experiencing this on

  • OS : Debian 9.9
  • MongoDB Version : 4.0.11
  • NodeJS Version : v8.16.0

@Yures
Copy link

Yures commented Oct 2, 2019 via email

@dca-adam
Copy link

dca-adam commented Oct 3, 2019

I am also experiencing this issue on both my test and prod environments.

  • Version of Rocket.Chat Server: 2.1.0
  • Operating System: CentOS 7.7.1908
  • Deployment Method: tar
  • Number of Running Instances: 1 (test and prod are independent instances)
  • DB Replicaset Oplog: Enabled
  • NodeJS Version: 8.11.4
  • MongoDB Version: 3.6.14

@johnbrown-yoti
Copy link

Same issue here.

  • Rocket.Chat Version: 2.1.0
  • NodeJS Version: 8.11.3 - x64
  • MongoDB Version: 3.6.14
  • Deployment Method: tar
  • Number of Running Instances: 3
  • ReplicaSet OpLog: Enabled

@gennari-dkt
Copy link

Same issue for me.

  • Version of Rocket.Chat Server: 2.1.0
  • Operating System: Debian 9.9
  • Deployment Method: tar
  • Number of Running Instances: 1 (test and prod are independent instances)
  • NodeJS Version: 8.11.4
  • MongoDB Version: 4.0.10

@bkraul
Copy link

bkraul commented Oct 9, 2019

Same issue here with develop (da6025e)

  • Version of Rocket.Chat Server: 2.2.0-develop
  • Operating System: Ubuntu 18.04 (docker)
  • Deployment Method: docker (develop tag)
  • Number of Running Instances: 1 (test and prod are independent instances)
  • NodeJS Version: v8.15.1
  • MongoDB Version: 4.0.12

I had posted an update where it seemed the problem was on only one DM channel, but no, it is across the board. Read receipts are not working at all, even when on in the system.

@reetp
Copy link

reetp commented Oct 15, 2019

This works in Custom CSS

.color-component-color {
    color: red !important;
}

Just curious. Why is it seeming to use use the 'Old' Colors and not the 'New' ones?

@geekgonecrazy
Copy link
Contributor

@ggazzo @tassoevan just making sure this is on your radar. Seems like css issue

@wreiske
Copy link
Contributor

wreiske commented Oct 16, 2019

This is NOT a CSS issue. I think the index added in #15316 doesn't allow multiple messageId's.

All of my db.rocketchat_message_read_receipt's show multiple items PRE upgrade. Now there is only one read receipt per message. The reason the blue check isn't showing is that all users haven't read the message.

I am only getting the owner of the message showing on the new read receipts in the database.

@bkraul
Copy link

bkraul commented Oct 16, 2019

The reason the blue check isn't showing is that all users haven't read the message.

I am positive all users in the DM conversation have read all messages that should be showing "read" but are not.

@wreiske
Copy link
Contributor

wreiske commented Oct 16, 2019

The reason the blue check isn't showing is that all users haven't read the message.

I am positive all users in the DM conversation have read all messages that should be showing "read" but are not.

Technically, they have not read the messages because RocketChat isn't saving that they read them. Only one read reciept is being saved per message. That is what I meant.

@bkraul
Copy link

bkraul commented Oct 16, 2019

Oh I got you. Apologies.

@phriedrich
Copy link
Author

Thanks to anyone involved fixing this. I can confirm it's working again.

@wreiske
Copy link
Contributor

wreiske commented Oct 22, 2019

Ahh I think the read receipts are still not working 100% of the time because we have rocket.cat in the channels. rocket.cat isn't reading the messages like it used to :'(, so the check never goes blue.

@reetp
Copy link

reetp commented Oct 22, 2019

I am only getting the owner of the message showing on the new read receipts in the database.

On 2.1.1

Is that still true?

"Info" only shows the owner having read a group message even though they must have all read it.

@Wirone
Copy link

Wirone commented Oct 23, 2019

We've updated to 2.1.1 and read receipts are working properly (information modal displays list of users who read the message), but as @wreiske said, bots cause that blue tick is not shown because they don't mark messages as read. Minor issue, but would be great if this could be fixed (maybe just ignore users with bot role when determining if tick should be displayed?).

@rodrigok
Copy link
Member

Good catch @Wirone we will check this.

@wreiske are you sure that your rocket.cat was reading the messages before? The only way I can see this happening today is if you use the APIs to call the readMessages for the rocket.cat user manually via some integration or so.

@wreiske
Copy link
Contributor

wreiske commented Oct 23, 2019

As it is right now with the latest 2.1.1 update.

When I go back to older messages that were sent during the 2.1.0 read brokenness, I only see one person, the original author. The check is blue.
dQtmfkIXPF

When I go back to older messages, BEFORE 2.1.0 read brokenness, I see everyone that had read the message. The check is blue.
jaSlWXe8dx

In a channel where rocket.cat has been invited in, BEFORE 2.1.0 read brokenness, rocket.cat read all messages after they were sent
Rocket Chat_ejtNBaILPO


Here's a message on 2.1.1 that shows the blue check, however, not everyone has read the message... or at least, the UI isn't showing everyone that has read it.

image
image

There are 16 users in this channel. Why is the check blue?
image

@rodrigok
Copy link
Member

@wreiske not sure if this will help. I could not reproduce your case of having a message marked as read with just a few participants.

@GoetheG
Copy link

GoetheG commented Nov 22, 2019

Shouldn't this issue be merged with all the other same isses? Cause this error still occurs with the latest version.
#4957
#15656
#15484

This was referenced Nov 22, 2019
@gerroon
Copy link

gerroon commented Apr 25, 2020

I do not see readd receipts with my setup. This used to work but when I do not remember.

3.0.12
Apps Engine Version	1.12.0
Database Migration	174
Database Migration Date	April 13, 2020 5:50 PM
Installed at	June 16, 2019 10:29 PM

OS Type	Linux
OS Platform	linux
OS Arch	x64
OS Release	5.4.0-4-amd64
Node Version	v12.14.0
Mongo Version	4.0.12
Mongo Storage Engine	mmapv1

@kgdemir
Copy link

kgdemir commented Sep 15, 2020

Read Receipts is Broken again, when I try to look any message before 3.6.0 update I can see individual receipts, but after the update it is just showing receipts for sender and current logged in account

@phriedrich
Copy link
Author

There's already a ticket for the new error: #18689

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment