Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVE] Add missing indices used by read receipts #15316

Merged
merged 3 commits into from
Sep 13, 2019

Conversation

sampaiodiego
Copy link
Member

@sampaiodiego sampaiodiego commented Sep 6, 2019

Adds two missing indices on Subscriptions collection used by read receipts queries:

{ rid: 1 }
{ rid: 1, ls: 1 }

And another on on ReadReceipts collection used to see who read a message:

{ messageId: 1 }

@sampaiodiego sampaiodiego added this to the 2.1.0 milestone Sep 6, 2019
ggazzo
ggazzo previously approved these changes Sep 6, 2019
@wreiske
Copy link
Contributor

wreiske commented Sep 11, 2019

I was just about to open an issue for this! The read receipts seem to take a really long time to load... I assume the new index helps the speed a bit? I was going to go digging but you beat me to it.

This is how long it takes currently:
9wmbLc8sdL

@sampaiodiego
Copy link
Member Author

I know for sure this indices helps on making rooms as read.. I can check if they help loading the list of users as well, or if there is missing index there too. thanks @wreiske

ggazzo
ggazzo previously approved these changes Sep 13, 2019
@sampaiodiego
Copy link
Member Author

@wreiske I've added an index that will help.. But there are other improvements to do to make that screen load faster 👍

@sampaiodiego sampaiodiego merged commit 72bdd6e into develop Sep 13, 2019
@sampaiodiego sampaiodiego deleted the add-missing-indices branch September 13, 2019 19:41
@wreiske
Copy link
Contributor

wreiske commented Sep 13, 2019

@wreiske I've added an index that will help.. But there are other improvements to do to make that screen load faster 👍

Awesome, thanks! I use the read receipt info multiple times a day. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants