Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVE] KaTeX and Autolinker message rendering #11698

Merged
merged 5 commits into from
Feb 12, 2019
Merged

[IMPROVE] KaTeX and Autolinker message rendering #11698

merged 5 commits into from
Feb 12, 2019

Conversation

tassoevan
Copy link
Contributor

This pull request aims to:

  • disable \href in KaTeX parser;
  • make autolinker ignore message tokens (slices of messages that should be ignored in parsers).

@tassoevan tassoevan self-assigned this Aug 7, 2018
@tassoevan tassoevan added this to the 0.69.0 milestone Aug 7, 2018
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11698 August 7, 2018 20:11 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11698 August 10, 2018 19:26 Inactive
@tassoevan tassoevan force-pushed the improve/message-rendering branch from 05d397e to 6cddddc Compare August 10, 2018 19:38
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11698 August 10, 2018 19:38 Inactive
@tassoevan tassoevan mentioned this pull request Aug 15, 2018
Closed
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11698 August 25, 2018 04:04 Inactive
@tassoevan tassoevan mentioned this pull request Aug 30, 2018
Closed
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11698 October 2, 2018 14:36 Inactive
@theorenck theorenck modified the milestones: 0.69.0, Short-term Dec 12, 2018
@tassoevan tassoevan force-pushed the improve/message-rendering branch from 3821638 to c76f408 Compare January 28, 2019 16:04
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11698 January 28, 2019 16:04 Inactive
@tassoevan tassoevan force-pushed the improve/message-rendering branch from c76f408 to 56f724b Compare January 28, 2019 16:06
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11698 January 28, 2019 16:06 Inactive
@tassoevan tassoevan modified the milestones: Short-term, 0.75.0 Jan 28, 2019
@ggazzo ggazzo merged commit 78b41a3 into develop Feb 12, 2019
@rodrigok rodrigok deleted the improve/message-rendering branch February 15, 2019 12:54
@rodrigok rodrigok mentioned this pull request Apr 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggazzo ggazzo ggazzo approved these changes

@rodrigok rodrigok Awaiting requested review from rodrigok

@sampaiodiego sampaiodiego Awaiting requested review from sampaiodiego

Assignees

@tassoevan tassoevan

Labels
feat: message type: bug ui/ux
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@tassoevan @ggazzo @engelgabriel @theorenck