Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Fixes bug in latex-parsing #9715

Closed
wants to merge 2 commits into from

Conversation

c0dzilla
Copy link
Contributor

@c0dzilla c0dzilla commented Feb 14, 2018

@RocketChat/core

Closes #9683
Latex rendering function was returning incorrect value leading to resulting message being of the form '=!=<Random.id()>=!='. This pr fixes this.

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9715 February 15, 2018 14:39 Inactive
@engelgabriel
Copy link
Member

Testing the PR I had the following result:

image

But I don't think that latex should be parsed at all inside code formatted boxes or inline code, what do you guys think?

@RocketChat/core ?

@c0dzilla
Copy link
Contributor Author

@engelgabriel presently latex parsing and markdown parsing callbacks on a message occur independently with latex parsing at higher priority. Latex parsing can be disabled in case inline/block code match occurs. Thoughts?

@nusje2000
Copy link

@c0dzilla I think the question should be, what would a user use more often. I think, based on my use case, people use codeblocks more often than latex parsing. Altho latex parsing could be usefull in some cases, I dont think it should be at a higher priority than inline/block code. But that is my opinion

@c0dzilla
Copy link
Contributor Author

c0dzilla commented Mar 4, 2018

@engelgabriel what is the status on this? Is there anything needed to be done?

@ggazzo ggazzo requested a review from tassoevan August 13, 2018 16:06
@ggazzo ggazzo added the ui/ux label Aug 13, 2018
@ggazzo ggazzo added this to the 0.69.0 milestone Aug 13, 2018
@tassoevan
Copy link
Contributor

Thank you for the contribution. However, I'm closing this PR because it collides with other related issues we've worked on, as you can see in #11698 and #11746.

@tassoevan tassoevan closed this Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Random string of characters when sending \([]\)
5 participants