Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX]Unable to edit "Custom Emoji" #21821

Closed
wants to merge 1 commit into from
Closed

[FIX]Unable to edit "Custom Emoji" #21821

wants to merge 1 commit into from

Conversation

PriyaBihani
Copy link
Contributor

@PriyaBihani PriyaBihani commented Apr 27, 2021

  • I have read the Contributing Guide
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Proposed changes (including videos or screenshots)

User was unable to update custom emoji if only the name and alias were to be updated, this PR resolves this issue making it possible to update just the name or alias of the custom emoji without changing the emoji file.

Previously
Just the name or alias couldn't be edited.

Now

Screen.Recording.2021-04-27.at.7.02.52.PM.mov

Issue(s)

#21819

Further comments

@PriyaBihani
Copy link
Contributor Author

PriyaBihani commented Apr 27, 2021

@ggazzo @KevLehman can you please take a look at it ?

@yash-rajpal
Copy link
Member

yash-rajpal commented Apr 27, 2021

I think PR #20318 will solve this issue.

@PriyaBihani
Copy link
Contributor Author

PriyaBihani commented Apr 27, 2021

@yash-rajpal #20318 doesn't seem to work now. I'd appreciate if you could corroborate.

@CLAassistant
Copy link

CLAassistant commented Dec 17, 2021

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants