Chore: Move presence to package #25541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging d4c2a7f into 86c0131 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 8bf46a5 into 41804a0 - view on LGTM.com new alerts:
|
Codecov Report
@@ Coverage Diff @@
## develop #25541 +/- ##
===========================================
+ Coverage 40.59% 40.61% +0.02%
===========================================
Files 790 790
Lines 17903 17903
Branches 1927 1927
===========================================
+ Hits 7268 7272 +4
+ Misses 10343 10340 -3
+ Partials 292 291 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
ggazzo
requested changes
Sep 14, 2022
apps/meteor/ee/tests/unit/server/services/presence/lib/processConnectionStatus.tests.ts
Outdated
Show resolved
Hide resolved
ggazzo
previously approved these changes
Sep 15, 2022
ggazzo
approved these changes
Sep 15, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
ARCH-26
Steps to test or reproduce
Further comments