-
Notifications
You must be signed in to change notification settings - Fork 11.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 5.2.0 #27063
Merged
Merged
Release 5.2.0 #27063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge master into develop & Set version to 5.2.0-develop
Co-authored-by: Douglas Fabris <27704687+dougfabris@users.noreply.github.com>
Co-authored-by: Douglas Fabris <27704687+dougfabris@users.noreply.github.com>
Co-authored-by: Luciano Marcos Pierdona Junior <64279791+LucianoPierdona@users.noreply.github.com>
Co-authored-by: Yash Rajpal <58601732+yash-rajpal@users.noreply.github.com>
Co-authored-by: Matheus Barbosa Silva <36537004+matheusbsilva137@users.noreply.github.com> Co-authored-by: Hugo Costa <20212776+hugocostadev@users.noreply.github.com>
Co-authored-by: Murtaza Patrawala <34130764+murtaza98@users.noreply.github.com>
Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat>
Co-authored-by: Guilherme Gazzo <5263975+ggazzo@users.noreply.github.com>
Co-authored-by: Douglas Fabris <27704687+dougfabris@users.noreply.github.com>
…Electron (#26793) Co-authored-by: Pierre Lehnen <55164754+pierre-lehnen-rc@users.noreply.github.com>
…ty processing (#27002) Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat>
…26994) * break LDAP manager into smaller pieces to improve unit tests * Fix * Apply suggestions from code review Co-authored-by: Diego Sampaio <chinello@gmail.com> * Apply suggestions from code review Co-authored-by: Pierre Lehnen <55164754+pierre-lehnen-rc@users.noreply.github.com> * Added few tests Co-authored-by: Diego Sampaio <chinello@gmail.com> Co-authored-by: Pierre Lehnen <55164754+pierre-lehnen-rc@users.noreply.github.com> Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat>
…27008) Co-authored-by: Kevin Aleman <kaleman960@gmail.com> Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat>
Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat>
This pull request introduces 1 alert and fixes 1 when merging 952ee99 into 4173a21 - view on LGTM.com new alerts:
fixed alerts:
|
ggazzo
approved these changes
Oct 13, 2022
d-gubert
approved these changes
Oct 13, 2022
Codecov Report
@@ Coverage Diff @@
## master #27063 +/- ##
==========================================
- Coverage 40.45% 40.18% -0.27%
==========================================
Files 799 827 +28
Lines 18300 18263 -37
Branches 1954 2020 +66
==========================================
- Hits 7403 7339 -64
- Misses 10603 10632 +29
+ Partials 294 292 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2022-10-13 · 5 🎉 · 13 🚀 · 19 🐛 · 62 🔍 · 28 👩💻👨💻
Engine versions
14.19.3
6.14.17
4.2, 4.4, 5.0
🎉 New features
Add Markup to QuoteAttachment (#26751)
Get moderators, owners and leaders from room scope via apps-engine (#26674)
Matrix Federation events coverage expansion (support for 5 more events) (#26705)
The goal of this PR is to add support for more events on Matrix Federation feature. The new supported events are:
Edit Messages;
Delete Messages
File Upload (including video and audio/voice messages);
Send emojis on messages;
Reactions.
Move administration links to an exclusive kebab menu (#26867)
Move administration links to an exclusive kebab menu.
Sections layout and featured apps for marketplace (#26514)
MKP??+ - Featured Apps
Implemented a new layout for marketplace's apps list page. Now the page has an All apps section and a "featured apps" section in which pre-selected and pre-categorized apps are dynamically shown on the top area of the page to make them stand out.

Demo gif:
ClickUp Task link: https://app.clickup.com/t/2t1w9x3
🚀 Improvements
Allow delete attachment description on message edit (#26673)
Better descriptions for VoIP Settings (#26877)
Changed dial pad appearance to match original design (#26863)
Before:

After:

Include
syncAvatars
onldap.syncNow
(#26824)This PR includes a new call for the method
syncAvatars
whenldap.syncNow
is calledOTR Message (#24297)
Results of user auto complete (#26687)
Rounded video attachment (#26832)
Setting for login email notifications (#26831)
System messages' consistency (#26130)
Updating voip tooltips and icons (#26834)
This PR includes the following tooltip expression changes:
Call toggle button
Enabled -> Turn off answer calls
Disabled -> Turn on answer calls
Signaling connection disconnected -> Waiting for server connection
Chat toggle button
Available -> Turn off answer chats
Not available -> Turn on answer chats
Hold button
Mute button
Also includes the following icon changes:
Old:



New:
Use cached EE Cloud license on startup (#26987)
VideoConference Messages UI (#26548)
VideoConference Messages UI ([IMPROVE] VideoConference Messages UI #26548)" (#26961)
🐛 Bug fixes
Livechat: Unread messages badge (#26843)
OC-169
Even if the page was reopening, Livechat will inform unread messages
Adjusted livechat fallbacks to take null values into account (#26909)
Admin sidebar navigation (#26958)
MKP-125
Fix the behavior of the admin sidebar, it didn't activate its options properly on pages that had sub-routes.

Demo gif:
Asset settings description not showing on admin (#26755)
Check admin setting for whether to display roles or not (#26601)
Ephemeral messages not respecting katex setting (#26812)
Expanded thread behind sidebar on small screens (#26852)
Sidebar overlapping expanded threads in window sizes between 1135px and 780px and but the expanded threads should be limited to sidebar size and should not go through it
Actual behavior
Expected behavior
Fix broken legacy message view (#26819)
Fixed
messagesHistory
function, it was filtering messages only with existing threads.Incorrect filter on contact history search (#26813 by @neo-clon)
Livechat trigger messages covering all the website (#26776)
Menu options margin spacing (#26775)
Message sequential after message thread preview (#26900)
MIME Type fallback for .mov File Extensions (#26921)
Some browsers don't support the MIME type for QuickTime video encoder (.mov), so we had to create a fallback to 'video/mp4'. There are other fallbacks for other browsers, but this is the only one we need for now.
The fallback func was used in the MediaPreview and VideoAttachments components
Old rooms without the associated unit will not be displayed on the current chats (#26685)
Restore current chats default table order (#26808)
Sign in with Apple on mobile (#26827)
Our mobile app uses a different method to log in that was removed at [FIX] Apple OAuth #24879 .
You can also make it available only on mobile:

Removes the "Sign in with Apple" text from the log in button. This was something we thought were required by Apple, but it is actually allowed to have just the logo as all others OAuth we have. Source: https://developer.apple.com/design/human-interface-guidelines/technologies/sign-in-with-apple/buttons/#creating-a-custom-sign-in-with-apple-button
Typo on new homepage (#26768)
Unable to send native video recording to Whatsapp (#26669)
Upload fails when using WebDav as file storage (#26711)
🔍 Minor changes
Bump actions/cache from 2 to 3.0.1 (#25003 by @dependabot[bot])
Chore:
improve/media-recorder
(#26426)Chore:
refactor/room
(#26675)Replaces
room
Blaze template with React components.Chore: add aria hidden if modal is open (#26826)
Chore: Add E2E tests to missing omnichannel endpoints (#26730)
Chore: Add RocketChatDesktop function to open video calls when using Electron (#26793)
Chore: Add tests to cover issue fixed in Regression: Empty custom-fields filter on Current Chats causing issues #26720 (#26767)
Chore: break LDAP manager into smaller pieces to improve unit tests (#26994)
Chore: Bump Apps-Engine version (#27059)
Chore: Bump fuselage dependencies and implement new tabs variant in marketplace (#26876)
Bumped the necessary dependencies of fuselage and implemented the new tabs component underline variant.

Demo image:
Chore: Bump fuselage to latest (#27042)
Chore: Bump vm2 to 3.9.11 (#26940)
Chore: Change BundleChips component appearance (#26686)
MKP-44
Changed the appearance of the marketplace app bundle chips (E.G.: The blue Enterprise tag in the images bellow).
Demo image for app details page:

Demo image for list view:

Chore: Cleanup endpoint handlers (#26749)
Chore: Configure Prettier for
@rocket.chat/livechat
(#26846)Chore: Convert current-chats to useQuery (#26931)
Chore: Deprecate some omnichannel meteor methods which aren't getting used (#26839)
Chore: first non-aggressive CSS removal (#26714)
Chore: Fix API tests retry (#26860)
Chore: fix regressions for omnichannel due room refactor (#26912)
Chore: fix wrong
test.step
usage (#26873)Chore: Introduce
useQuery
as data source for theRoom
component (#26855)Chore: merge all functions using autorun x useSubscription pattern (#26886)
Chore: Missing Also_send_thread_message_to_channel setting translation (#26926)
Chore: Move Header to ui-client (#26757)
Chore: Move micro services to packages (#26884)
Chore: Move Omnichannel Room Footer to react (#26864)
Chore: Move presence to package (#25541)
Chore: Omnichannel endpoints to ts (#26829)
Chore: Refactor message list context usage (#26748)
Chore: Refactor omnichannel livechat tests (#26929)
Chore: Rewrite apps WarningModal component to typescript (#26845)
Translated the admin apps WarningModal component from Javascript to Typescript
Chore: Test/improve reliability (#26724)
Chore: Tests for EE features (#26939)
Chore: Update fuselage to next version. (#26841)
Chore: Updating apps engine (#26924)
Chore: Upgrading livechat's ui-kit package to latest version (#26709)
This PR upgrades Livechat's UiKit package to the version 0.31.16. and adjusts the renderer to be compatible with said version.
i18n: Language update from LingoHub 🤖 on 2022-08-29Z (#26722)
i18n: Language update from LingoHub 🤖 on 2022-09-05Z (#26805)
i18n: Language update from LingoHub 🤖 on 2022-09-12Z (#26849)
i18n: Language update from LingoHub 🤖 on 2022-09-19Z (#26896)
i18n: Language update from LingoHub 🤖 on 2022-09-26Z (#26948)
Merge master into develop & Set version to 5.2.0-develop (#26792)
Regression: Cannot edit messages in some environments. (#27023)
An empty
$unset
object was being used and causes exceptions in some mongo versions.Regression: Composer not reactive when omnichannel room closed (#26983)
Regression: Double Table Cell Causing extra padding on Current Chats (#27008)
Regression: Event handler blocking mention links (#26964)
Fixes mention links being irresponsive to clicks.
Jira: TC-55
Regression: Fix open room from current chats (#26930)
Regression: Fixed takeInquiry method not displaying error messages on the client (#26976)
This pull request brings back the toast message "The maximum number of simultaneous chats per agent has been reached." that should be displayed when an agent tries to take more chats than the maximum allowed.
Regression: Handle
undefined
values onuseReactiveQuery
's query function (#26988)According to https://tanstack.com/query/v4/docs/reference/useQuery, the query function must not return
undefined
values, a quirk that we've been ignoring.Regression: Incorrect on-hold chat resume message (#26935)
Regression: Omnichannel Contact Center empty on no filter search (#26975)
Regression: Remove section and replace icon on administration kebab menu (#26986)
Regression: Remove symbols from number before storing PBX event (#26969)
Regression: Sidebar Room List not working properly. (#26950)
The CachedCollection Class was assuming that the passed parameter would be modified, instead of using the callback return.
Regression: Typo on livechat/queue endpoint client call (#26962)
Regression: Use raw models instead of meteor ones on visitor inactivity processing (#27002)
Regression: VideoConf Actions Reactivity in SidebarItem (#27009)
Jira Issue: [VC-10]
Regression: wrong permission on livechat/tags endpoints (#26928)
Release 5.1.1 (#26822)
Release 5.1.3 (#26914)
Release 5.1.4 (#26965)
👩💻👨💻 Contributors 😍
👩💻👨💻 Core Team 🤓