Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: first non-aggressive CSS removal #26714

Merged
merged 3 commits into from
Sep 9, 2022
Merged

Chore: first non-aggressive CSS removal #26714

merged 3 commits into from
Sep 9, 2022

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Aug 26, 2022

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #26714 (f697baa) into develop (01c8786) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26714      +/-   ##
===========================================
+ Coverage    40.54%   40.61%   +0.07%     
===========================================
  Files          799      798       -1     
  Lines        18296    18274      -22     
  Branches      1954     1954              
===========================================
+ Hits          7418     7422       +4     
+ Misses       10583    10557      -26     
  Partials       295      295              
Flag Coverage Δ
e2e 40.61% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo marked this pull request as ready for review September 8, 2022 14:18
@ggazzo ggazzo requested a review from a team as a code owner September 8, 2022 14:18
Copy link
Member

@MartinSchoeler MartinSchoeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't find any obvious styling issues on the omnichannel side. LGTM

@ggazzo ggazzo added stat: QA skipped stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Sep 9, 2022
@ggazzo ggazzo merged commit 5fdf20b into develop Sep 9, 2022
@ggazzo ggazzo deleted the chore/css-prunning branch September 9, 2022 18:34
@tassoevan tassoevan mentioned this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants