Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVE] Updating voip tooltips and icons #26834

Merged
merged 11 commits into from
Sep 19, 2022
Merged

Conversation

aleksandernsilva
Copy link
Contributor

@aleksandernsilva aleksandernsilva commented Sep 8, 2022

OC-36

Proposed changes (including videos or screenshots)

This PR includes the following tooltip expression changes:

Call toggle button

  • Enabled -> Turn off answer calls
  • Disabled -> Turn on answer calls
  • Signaling connection disconnected -> Waiting for server connection

Chat toggle button

  • Available -> Turn off answer chats
  • Not available -> Turn on answer chats

Hold button

  • Hold call -> Hold call / Resume call

Mute button

  • Mute -> Turn on microphone / Turn off microphone

Also includes the following icon changes:

Old:
new-1
new-2
new-3

New:

old-1
old-2
old-3

Issue(s)

Steps to test or reproduce

Further comments

@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #26834 (8b58a97) into develop (1e1b47e) will decrease coverage by 0.09%.
The diff coverage is n/a.

❗ Current head 8b58a97 differs from pull request most recent head 64d0b1e. Consider uploading reports for the commit 64d0b1e to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26834      +/-   ##
===========================================
- Coverage    40.74%   40.65%   -0.10%     
===========================================
  Files          791      790       -1     
  Lines        17809    17903      +94     
  Branches      1928     1927       -1     
===========================================
+ Hits          7256     7278      +22     
- Misses       10257    10331      +74     
+ Partials       296      294       -2     
Flag Coverage Δ
e2e 40.65% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@aleksandernsilva aleksandernsilva marked this pull request as ready for review September 9, 2022 14:09
@aleksandernsilva aleksandernsilva requested a review from a team as a code owner September 9, 2022 14:09
MartinSchoeler
MartinSchoeler previously approved these changes Sep 12, 2022
@ggazzo ggazzo added the stat: ready to merge PR tested and approved waiting for merge label Sep 19, 2022
@kodiakhq kodiakhq bot merged commit 7905852 into develop Sep 19, 2022
@kodiakhq kodiakhq bot deleted the improve/voip-tooltips-icons branch September 19, 2022 17:30
@tassoevan tassoevan mentioned this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad: omnichannel stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants