Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: merge all functions using autorun x useSubscription pattern #26886

Merged
merged 2 commits into from
Sep 16, 2022

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Sep 16, 2022

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@ggazzo ggazzo force-pushed the chore/reuse-autoruns-hook branch from e0b0f50 to 61f50b8 Compare September 16, 2022 04:44
@RocketChat RocketChat deleted a comment from lgtm-com bot Sep 16, 2022
@ggazzo ggazzo added stat: QA skipped stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Sep 16, 2022
@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Merging #26886 (909fcdf) into develop (40dd7bb) will decrease coverage by 0.21%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26886      +/-   ##
===========================================
- Coverage    40.97%   40.76%   -0.22%     
===========================================
  Files          790      791       +1     
  Lines        17835    17809      -26     
  Branches      1929     1928       -1     
===========================================
- Hits          7308     7259      -49     
- Misses       10234    10256      +22     
- Partials       293      294       +1     
Flag Coverage Δ
e2e 40.76% <100.00%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo marked this pull request as ready for review September 16, 2022 13:23
@ggazzo ggazzo requested a review from a team as a code owner September 16, 2022 13:23
@kodiakhq kodiakhq bot merged commit f9676c6 into develop Sep 16, 2022
@kodiakhq kodiakhq bot deleted the chore/reuse-autoruns-hook branch September 16, 2022 13:23
@tassoevan tassoevan mentioned this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants