Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Incorrect filter on contact history search #26813

Merged
merged 7 commits into from
Sep 15, 2022

Conversation

neo-clon
Copy link
Contributor

@neo-clon neo-clon commented Sep 5, 2022

searchChats have closedChatsOnly and served condition wrong, this make as result that not appear Chat History on the room

I fix the conditions to return the correct chats.

searchChats have closedChatsOnly and served condition wrong, this make as result that not appear Chat History on the room
@neo-clon neo-clon requested a review from a team as a code owner September 5, 2022 23:50
@CLAassistant
Copy link

CLAassistant commented Sep 5, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@murtaza98 murtaza98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@murtaza98 murtaza98 changed the title Fix searchChats function [FIX] Incorrect filter on contact history seach Sep 6, 2022
@murtaza98 murtaza98 changed the title [FIX] Incorrect filter on contact history seach [FIX] Incorrect filter on contact history search Sep 6, 2022
@neo-clon
Copy link
Contributor Author

I need something else to merge this fix?

@ggazzo ggazzo merged commit 18b7b4b into RocketChat:develop Sep 15, 2022
tassoevan pushed a commit that referenced this pull request Sep 15, 2022
Co-authored-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
Co-authored-by: Kevin Aleman <kaleman960@gmail.com>
@neo-clon neo-clon deleted the patch-1 branch September 15, 2022 15:39
@tassoevan tassoevan mentioned this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants