Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVE] OTR Message #24297

Merged
merged 62 commits into from
Sep 6, 2022
Merged

[IMPROVE] OTR Message #24297

merged 62 commits into from
Sep 6, 2022

Conversation

albuquerquefabio
Copy link
Contributor

@albuquerquefabio albuquerquefabio commented Jan 26, 2022

  • Now we are sending OTR messages through streamer without saving them on the database.
  • The OTR Key now is updated without ending OTR.
  • Old OTR methods were removed.

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@lgtm-com
Copy link

lgtm-com bot commented Jan 31, 2022

This pull request introduces 1 alert when merging 6aed46e into dfd22ee - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Feb 2, 2022

This pull request introduces 1 alert when merging ee421b6 into 3a47726 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Feb 22, 2022

This pull request introduces 1 alert when merging a25f992 into 7346a70 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Feb 22, 2022

This pull request introduces 2 alerts when merging 7d1d9d4 into 550bfb0 - view on LGTM.com

new alerts:

  • 1 for Syntax error
  • 1 for Unused variable, import, function or class

@yash-rajpal yash-rajpal force-pushed the improve/otr-message branch from c9a03d2 to 87c2355 Compare March 2, 2022 19:17
@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #24297 (55addb8) into develop (01c8786) will decrease coverage by 0.02%.
The diff coverage is 8.69%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #24297      +/-   ##
===========================================
- Coverage    40.54%   40.51%   -0.03%     
===========================================
  Files          799      799              
  Lines        18296    18288       -8     
  Branches      1954     1958       +4     
===========================================
- Hits          7418     7410       -8     
+ Misses       10583    10579       -4     
- Partials       295      299       +4     
Flag Coverage Δ
e2e 40.51% <8.69%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

albuquerquefabio and others added 11 commits August 17, 2022 10:12
…ove/otr-message

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Regression: Add alsoSendThreadToChannel to user settings api (#26663)
  [IMPROVE] Spotlight search user results (#26599)
  [FIX] Slack User CSV importer not working (#26629)
  Chore: Importer rest types, meteor methods to TS and API unit tests (#26284)
  [NEW] Adding oauth crud on the rocket.chat side (#26220)
  [NEW] allow ephemeral messages to receive a specific id (#26118)
  [FIX] MDM content alignment (#26665)
  Chore: Permissions check per endpoint/method (#26419)
  Regression: CI (#26658)
  [FIX] Not allowed error in discussion room with a private parent channel (#26394)
  Chore: Fix grammatical typo when only one message is pruned (#21902)
  [FIX] Agents (with user status offline & omni-status as available) not able to take or forward chat (#26575)
  i18n: Language update from LingoHub 🤖 on 2022-08-22Z (#26645)
  Chore: Add license env var to ee tests (#26650)
  Chore: Move `Card` and related components to `@rocket.chat/ui-client` (#26653)
  Regression: Custom status loading forever in Usercard (#26656)
  [FIX] Current Chat Custom Field Filter (#26200)
  Chore: Migrate modules related to `room` template to TypeScript (#25881)
  Chore: Create teams management tests (#26578)
@ggazzo ggazzo added the stat: ready to merge PR tested and approved waiting for merge label Aug 31, 2022
@alvaropmello alvaropmello added this to the 5.2.0 milestone Sep 5, 2022
@kodiakhq kodiakhq bot merged commit 7acbb2a into develop Sep 6, 2022
@kodiakhq kodiakhq bot deleted the improve/otr-message branch September 6, 2022 19:09
@tassoevan tassoevan mentioned this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants