-
Notifications
You must be signed in to change notification settings - Fork 11.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Agents (with user status offline & omni-status as available) not able to take or forward chat #26575
Conversation
…t able to take chat
Codecov Report
@@ Coverage Diff @@
## develop #26575 +/- ##
===========================================
+ Coverage 37.97% 38.64% +0.66%
===========================================
Files 778 751 -27
Lines 18854 18670 -184
Branches 1932 1453 -479
===========================================
+ Hits 7160 7215 +55
+ Misses 11400 11237 -163
+ Partials 294 218 -76
Flags with carried forward coverage won't be shown. Click here to find out more. |
three things,
|
Lol, no, this is not a regression. Changed the title. The other 2 points, @murtaza98 |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have a special test waiting the agent number 2 get online to transfer
await test.step('Expect to connect as agent 2', async () => {
agent2 = await createAuxContext(browser, 'user2-session.json'); <---- HERE
please create a second test trying to assign to a offline agent as well
thanks
…lowed to transfer to offline agents
Added this test case as well here ✔️ |
…ove/otr-message * 'develop' of github.com:RocketChat/Rocket.Chat: Regression: Add alsoSendThreadToChannel to user settings api (#26663) [IMPROVE] Spotlight search user results (#26599) [FIX] Slack User CSV importer not working (#26629) Chore: Importer rest types, meteor methods to TS and API unit tests (#26284) [NEW] Adding oauth crud on the rocket.chat side (#26220) [NEW] allow ephemeral messages to receive a specific id (#26118) [FIX] MDM content alignment (#26665) Chore: Permissions check per endpoint/method (#26419) Regression: CI (#26658) [FIX] Not allowed error in discussion room with a private parent channel (#26394) Chore: Fix grammatical typo when only one message is pruned (#21902) [FIX] Agents (with user status offline & omni-status as available) not able to take or forward chat (#26575) i18n: Language update from LingoHub 🤖 on 2022-08-22Z (#26645) Chore: Add license env var to ee tests (#26650) Chore: Move `Card` and related components to `@rocket.chat/ui-client` (#26653) Regression: Custom status loading forever in Usercard (#26656) [FIX] Current Chat Custom Field Filter (#26200) Chore: Migrate modules related to `room` template to TypeScript (#25881) Chore: Create teams management tests (#26578)
…t able to take or forward chat (#26575)
Proposed changes (including videos or screenshots)
Issue(s)
Issue mentioned here
Steps to test or reproduce
Further comments
Note: this PR was built on top of #26147 to fix the issue raised by QA