[NEW] Adding oauth crud on the rocket.chat side #26220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #26220 +/- ##
===========================================
- Coverage 38.58% 38.41% -0.17%
===========================================
Files 794 794
Lines 19002 19002
Branches 1937 1937
===========================================
- Hits 7331 7299 -32
- Misses 11378 11411 +33
+ Partials 293 292 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
d-gubert
approved these changes
Aug 22, 2022
ggazzo
added
stat: ready to merge
ggazzo
approved these changes
Aug 24, 2022
gabriellsh
added a commit
that referenced
this pull request
Aug 24, 2022
…ove/otr-message * 'develop' of github.com:RocketChat/Rocket.Chat: Regression: Add alsoSendThreadToChannel to user settings api (#26663) [IMPROVE] Spotlight search user results (#26599) [FIX] Slack User CSV importer not working (#26629) Chore: Importer rest types, meteor methods to TS and API unit tests (#26284) [NEW] Adding oauth crud on the rocket.chat side (#26220) [NEW] allow ephemeral messages to receive a specific id (#26118) [FIX] MDM content alignment (#26665) Chore: Permissions check per endpoint/method (#26419) Regression: CI (#26658) [FIX] Not allowed error in discussion room with a private parent channel (#26394) Chore: Fix grammatical typo when only one message is pruned (#21902) [FIX] Agents (with user status offline & omni-status as available) not able to take or forward chat (#26575) i18n: Language update from LingoHub 🤖 on 2022-08-22Z (#26645) Chore: Add license env var to ee tests (#26650) Chore: Move `Card` and related components to `@rocket.chat/ui-client` (#26653) Regression: Custom status loading forever in Usercard (#26656) [FIX] Current Chat Custom Field Filter (#26200) Chore: Migrate modules related to `room` template to TypeScript (#25881) Chore: Create teams management tests (#26578)
csuadev
pushed a commit
that referenced
this pull request
Aug 26, 2022
Co-authored-by: Douglas Gubert <1810309+d-gubert@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This PR adds the CRUD bridge of OAuth apps registration, I will be needed for the future Zapier app, this PR comes along with the PR on the Apps.Engine side.
The idea's very simple, the app will be able to create, get (by id and name) delete and purge OAuth registration.
I took as an example the Zapier registration and I added the appId along with it.
It's my first full bridge, so feel free to send any constructive advice/feedback.
PS: I added some unit tests, since I am not too familiar with the Alsatian, it may look too simple.
Issue(s)
Steps to test or reproduce
Further comments