[IMPROVE] Spotlight search user results #26599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #26599 +/- ##
===========================================
- Coverage 38.44% 38.33% -0.12%
===========================================
Files 794 794
Lines 19002 19002
Branches 1937 1937
===========================================
- Hits 7306 7284 -22
- Misses 11403 11423 +20
- Partials 293 295 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
kodiakhq
bot
removed
the
stat: ready to merge
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
sampaiodiego
approved these changes
Aug 24, 2022
gabriellsh
added a commit
that referenced
this pull request
Aug 24, 2022
…ove/otr-message * 'develop' of github.com:RocketChat/Rocket.Chat: Regression: Add alsoSendThreadToChannel to user settings api (#26663) [IMPROVE] Spotlight search user results (#26599) [FIX] Slack User CSV importer not working (#26629) Chore: Importer rest types, meteor methods to TS and API unit tests (#26284) [NEW] Adding oauth crud on the rocket.chat side (#26220) [NEW] allow ephemeral messages to receive a specific id (#26118) [FIX] MDM content alignment (#26665) Chore: Permissions check per endpoint/method (#26419) Regression: CI (#26658) [FIX] Not allowed error in discussion room with a private parent channel (#26394) Chore: Fix grammatical typo when only one message is pruned (#21902) [FIX] Agents (with user status offline & omni-status as available) not able to take or forward chat (#26575) i18n: Language update from LingoHub 🤖 on 2022-08-22Z (#26645) Chore: Add license env var to ee tests (#26650) Chore: Move `Card` and related components to `@rocket.chat/ui-client` (#26653) Regression: Custom status loading forever in Usercard (#26656) [FIX] Current Chat Custom Field Filter (#26200) Chore: Migrate modules related to `room` template to TypeScript (#25881) Chore: Create teams management tests (#26578)
gabriellsh
added a commit
that referenced
this pull request
Aug 26, 2022
…hreads * 'develop' of github.com:RocketChat/Rocket.Chat: (93 commits) Chore: Upgrade dependencies (#26694) Chore: More Omnichannel tests (#26691) Regression: Banner - Room not found - Omnichannel room (#26693) [NEW] Capability to search visitors by custom fields (#26312) Chore: Create tests for Omnichannel admin add a custom fields (#26609) [FIX] Avatars of other chats disappear when they located near chat with broken avatar (#26689) [IMPROVE] Added identification on calls to/from existing contacts (#26334) Regression: invalid statistics format (#26684) Regression: "Cache size is not a function" error when booting (#26683) [FIX] Correct IMAP configuration for email inbox (#25789) [FIX] Active users count on `@all` and `@here` (#25957) [FIX] Autotranslate method should respect setting (#26549) Chore: Remove italic/bold font-style from system messages (#26655) Chore: Convert AppSetting to tsx (#26625) Chore: Remove & Test old closeChat templates (#26631) [IMPROVE] General federation improvements (#26150) [NEW] Warn admins about running multiple instances of the monolith (#26667) Regression: Prevent message from being temp forever (#26668) Regression: Add alsoSendThreadToChannel to user settings api (#26663) [IMPROVE] Spotlight search user results (#26599) ...
csuadev
pushed a commit
that referenced
this pull request
Aug 26, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Change the spotlight search so that when the user doesn't have permission to view users outside rooms, it instead will search for users that are subscribed to the same rooms as the requester. Sorting the results by the number of shared rooms.
The mention auto complete will also look for users in DMs before looking for other users outside the room.
Issue(s)
Steps to test or reproduce
Further comments