Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVE] Added identification on calls to/from existing contacts #26334

Merged
merged 53 commits into from
Aug 25, 2022

Conversation

aleksandernsilva
Copy link
Contributor

@aleksandernsilva aleksandernsilva commented Jul 21, 2022

Proposed changes (including videos or screenshots)

Before:
Screen Shot 2022-07-02 at 01 50 52

After:
Screen Shot 2022-07-21 at 16 00 27

Issue(s)

Steps to test or reproduce

Further comments

@aleksandernsilva aleksandernsilva marked this pull request as ready for review July 22, 2022 16:11
@aleksandernsilva aleksandernsilva requested review from a team as code owners July 22, 2022 16:11
@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #26334 (6b74f77) into develop (68bc2ae) will decrease coverage by 0.04%.
The diff coverage is 45.45%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26334      +/-   ##
===========================================
- Coverage    38.67%   38.62%   -0.05%     
===========================================
  Files          792      793       +1     
  Lines        18894    18900       +6     
  Branches      1937     1939       +2     
===========================================
- Hits          7307     7301       -6     
- Misses       11297    11309      +12     
  Partials       290      290              
Flag Coverage Δ
e2e 38.62% <45.45%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo force-pushed the improve/call-contact-id branch 2 times, most recently from ee4484f to 52dba05 Compare August 25, 2022 03:51
Copy link
Member

@ggazzo ggazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can ask you to check the two TODO: that I'd inserted? thanks

ggazzo
ggazzo previously approved these changes Aug 25, 2022
tiagoevanp
tiagoevanp previously approved these changes Aug 25, 2022
tiagoevanp
tiagoevanp previously approved these changes Aug 25, 2022
@KevLehman KevLehman requested a review from ggazzo August 25, 2022 18:02
@kodiakhq kodiakhq bot merged commit 10932a5 into develop Aug 25, 2022
@kodiakhq kodiakhq bot deleted the improve/call-contact-id branch August 25, 2022 19:48
gabriellsh added a commit that referenced this pull request Aug 26, 2022
…hreads

* 'develop' of github.com:RocketChat/Rocket.Chat: (93 commits)
  Chore: Upgrade dependencies (#26694)
  Chore: More Omnichannel tests (#26691)
  Regression: Banner - Room not found - Omnichannel room (#26693)
  [NEW] Capability to search visitors by custom fields (#26312)
  Chore: Create tests for Omnichannel admin add a custom fields (#26609)
  [FIX] Avatars of other chats disappear when they located near chat with broken avatar (#26689)
  [IMPROVE] Added identification on calls to/from existing contacts (#26334)
  Regression: invalid statistics format  (#26684)
  Regression: "Cache size is not a function" error when booting (#26683)
  [FIX] Correct IMAP configuration for email inbox (#25789)
  [FIX] Active users count on `@all` and `@here`  (#25957)
  [FIX] Autotranslate method should respect setting (#26549)
  Chore: Remove italic/bold font-style from system messages (#26655)
  Chore: Convert AppSetting to tsx (#26625)
  Chore: Remove & Test old closeChat templates (#26631)
  [IMPROVE] General federation improvements (#26150)
  [NEW] Warn admins about running multiple instances of the monolith (#26667)
  Regression: Prevent message from being temp forever (#26668)
  Regression: Add alsoSendThreadToChannel to user settings api (#26663)
  [IMPROVE] Spotlight search user results (#26599)
  ...
csuadev pushed a commit that referenced this pull request Aug 26, 2022
…6334)

Co-authored-by: Kevin Aleman <11577696+KevLehman@users.noreply.github.com>
Co-authored-by: Murtaza Patrawala <34130764+murtaza98@users.noreply.github.com>
Co-authored-by: Guilherme Gazzo <5263975+ggazzo@users.noreply.github.com>
@murtaza98 murtaza98 mentioned this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants