Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: More Omnichannel tests #26691

Merged
merged 8 commits into from
Aug 26, 2022
Merged

Chore: More Omnichannel tests #26691

merged 8 commits into from
Aug 26, 2022

Conversation

KevLehman
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

sampaiodiego
sampaiodiego previously approved these changes Aug 25, 2022
@ggazzo ggazzo added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Aug 25, 2022
sampaiodiego
sampaiodiego previously approved these changes Aug 25, 2022
@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #26691 (13587fc) into develop (862bd08) will increase coverage by 0.49%.
The diff coverage is 100.00%.

❗ Current head 13587fc differs from pull request most recent head 173c87f. Consider uploading reports for the commit 173c87f to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26691      +/-   ##
===========================================
+ Coverage    38.52%   39.02%   +0.49%     
===========================================
  Files          793      802       +9     
  Lines        18900    19048     +148     
  Branches      1939     1939              
===========================================
+ Hits          7281     7433     +152     
+ Misses       11330    11323       -7     
- Partials       289      292       +3     
Flag Coverage Δ
e2e 39.02% <100.00%> (+0.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman added this to the 5.1.0 milestone Aug 25, 2022
cauefcr
cauefcr previously approved these changes Aug 25, 2022
Copy link
Contributor

@cauefcr cauefcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, e2e tests are great to have.

@kodiakhq kodiakhq bot removed the stat: ready to merge PR tested and approved waiting for merge label Aug 25, 2022
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Aug 25, 2022

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

@KevLehman KevLehman dismissed stale reviews from cauefcr and sampaiodiego via 13587fc August 25, 2022 23:13
@KevLehman KevLehman added the stat: ready to merge PR tested and approved waiting for merge label Aug 25, 2022
@ggazzo ggazzo merged commit 4344746 into develop Aug 26, 2022
@ggazzo ggazzo deleted the chore/more-tests branch August 26, 2022 05:59
gabriellsh added a commit that referenced this pull request Aug 26, 2022
…hreads

* 'develop' of github.com:RocketChat/Rocket.Chat: (93 commits)
  Chore: Upgrade dependencies (#26694)
  Chore: More Omnichannel tests (#26691)
  Regression: Banner - Room not found - Omnichannel room (#26693)
  [NEW] Capability to search visitors by custom fields (#26312)
  Chore: Create tests for Omnichannel admin add a custom fields (#26609)
  [FIX] Avatars of other chats disappear when they located near chat with broken avatar (#26689)
  [IMPROVE] Added identification on calls to/from existing contacts (#26334)
  Regression: invalid statistics format  (#26684)
  Regression: "Cache size is not a function" error when booting (#26683)
  [FIX] Correct IMAP configuration for email inbox (#25789)
  [FIX] Active users count on `@all` and `@here`  (#25957)
  [FIX] Autotranslate method should respect setting (#26549)
  Chore: Remove italic/bold font-style from system messages (#26655)
  Chore: Convert AppSetting to tsx (#26625)
  Chore: Remove & Test old closeChat templates (#26631)
  [IMPROVE] General federation improvements (#26150)
  [NEW] Warn admins about running multiple instances of the monolith (#26667)
  Regression: Prevent message from being temp forever (#26668)
  Regression: Add alsoSendThreadToChannel to user settings api (#26663)
  [IMPROVE] Spotlight search user results (#26599)
  ...
csuadev pushed a commit that referenced this pull request Aug 26, 2022
Co-authored-by: Cauê Felchar <11652381+cauefcr@users.noreply.github.com>
@murtaza98 murtaza98 mentioned this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants