[FIX] Avatars of other chats disappear when they located near chat with broken avatar #26689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabriellsh
approved these changes
Aug 25, 2022
ggazzo
added
stat: QA skipped
stat: ready to merge
Codecov Report
@@ Coverage Diff @@
## develop #26689 +/- ##
===========================================
+ Coverage 38.52% 38.66% +0.14%
===========================================
Files 793 793
Lines 18900 18900
Branches 1939 1939
===========================================
+ Hits 7281 7308 +27
+ Misses 11328 11302 -26
+ Partials 291 290 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Thanks a lot!!! |
gabriellsh
added a commit
that referenced
this pull request
Aug 26, 2022
…hreads * 'develop' of github.com:RocketChat/Rocket.Chat: (93 commits) Chore: Upgrade dependencies (#26694) Chore: More Omnichannel tests (#26691) Regression: Banner - Room not found - Omnichannel room (#26693) [NEW] Capability to search visitors by custom fields (#26312) Chore: Create tests for Omnichannel admin add a custom fields (#26609) [FIX] Avatars of other chats disappear when they located near chat with broken avatar (#26689) [IMPROVE] Added identification on calls to/from existing contacts (#26334) Regression: invalid statistics format (#26684) Regression: "Cache size is not a function" error when booting (#26683) [FIX] Correct IMAP configuration for email inbox (#25789) [FIX] Active users count on `@all` and `@here` (#25957) [FIX] Autotranslate method should respect setting (#26549) Chore: Remove italic/bold font-style from system messages (#26655) Chore: Convert AppSetting to tsx (#26625) Chore: Remove & Test old closeChat templates (#26631) [IMPROVE] General federation improvements (#26150) [NEW] Warn admins about running multiple instances of the monolith (#26667) Regression: Prevent message from being temp forever (#26668) Regression: Add alsoSendThreadToChannel to user settings api (#26663) [IMPROVE] Spotlight search user results (#26599) ...
csuadev
pushed a commit
that referenced
this pull request
Aug 26, 2022
…th broken avatar (#26689) Co-authored-by: gabriellsh <40830821+gabriellsh@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Screen.Recording.2022-08-25.at.16.05.48.mov
Further comments
During the list re-render on the sidebar, React was have some issues rendering the correct element for the room avatar component, passing a key prop to a component will allow React engine track better dom changes.