Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Message sequential after message thread preview #26900

Merged
merged 6 commits into from
Sep 22, 2022
Merged

[FIX] Message sequential after message thread preview #26900

merged 6 commits into from
Sep 22, 2022

Conversation

filipemarins
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Message sequential after message thread preview

Before:
Screen Shot 2022-09-19 at 11 37 36

After:
Screen Shot 2022-09-19 at 11 37 09

@filipemarins filipemarins requested a review from a team as a code owner September 19, 2022 14:38
@codecov
Copy link

codecov bot commented Sep 19, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (develop@55e11c4). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop   #26900   +/-   ##
==========================================
  Coverage           ?   40.84%           
==========================================
  Files              ?      793           
  Lines              ?    17851           
  Branches           ?     1940           
==========================================
  Hits               ?     7291           
  Misses             ?    10263           
  Partials           ?      297
Flag Coverage Δ
e2e 40.84% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

guijun13
guijun13 previously approved these changes Sep 19, 2022
View reviewed changes
Copy link
Contributor

@guijun13 guijun13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@filipemarins filipemarins requested a review from a team as a code owner September 20, 2022 14:16
hugocostadev
hugocostadev previously approved these changes Sep 20, 2022
View reviewed changes
@ggazzo ggazzo added the stat: ready to merge PR tested and approved waiting for merge label Sep 20, 2022
@filipemarins filipemarins added this to the 5.2.0 milestone Sep 21, 2022
@ggazzo
Copy link
Member

ggazzo commented Sep 22, 2022

I had to change the code because the solution was introducing a different bug (messages from the same thread were never grouping).
and makes no sense testing the functions alone, if the results are mixed, they be tested together

@kodiakhq kodiakhq bot merged commit 548d8e6 into develop Sep 22, 2022
@kodiakhq kodiakhq bot deleted the fix/sequential branch September 22, 2022 23:14
@tassoevan tassoevan mentioned this pull request Oct 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggazzo ggazzo ggazzo approved these changes

@hugocostadev hugocostadev hugocostadev left review comments

@guijun13 guijun13 guijun13 left review comments

Assignees
No one assigned
Labels
squad: team-collab stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.
6 participants
@filipemarins @ggazzo @hugocostadev @guijun13 @alvaropmello @LevyCosta