[FIX] [Livechat] Unread messages badge #26843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiagoevanp
force-pushed
the
fix/livechat-reload-messages-unreaded
branch
from
5169ce0 to
0784c2f
Compare
Codecov Report
@@ Coverage Diff @@
## develop #26843 +/- ##
===========================================
- Coverage 40.95% 40.81% -0.14%
===========================================
Files 791 791
Lines 17809 17809
Branches 1928 1928
===========================================
- Hits 7293 7269 -24
- Misses 10222 10245 +23
- Partials 294 295 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
…livechat-reload-messages-unreaded
aleksandernsilva
previously requested changes
Sep 12, 2022
…livechat-reload-messages-unreaded
…livechat-reload-messages-unreaded
MartinSchoeler
requested changes
Sep 16, 2022
Co-authored-by: Martin Schoeler <martin.schoeler@rocket.chat>
Co-authored-by: Martin Schoeler <martin.schoeler@rocket.chat>
Co-authored-by: Martin Schoeler <martin.schoeler@rocket.chat>
Co-authored-by: Martin Schoeler <martin.schoeler@rocket.chat>
Co-authored-by: Martin Schoeler <martin.schoeler@rocket.chat>
Co-authored-by: Martin Schoeler <martin.schoeler@rocket.chat>
MartinSchoeler
previously approved these changes
Sep 16, 2022
ggazzo
added
stat: ready to merge
tiagoevanp
commented
Sep 21, 2022
apps/meteor/client/components/Omnichannel/modals/CloseChatModal.tsx
Outdated
Show resolved
Hide resolved
aleksandernsilva
approved these changes
Sep 21, 2022
ggazzo
reviewed
Sep 21, 2022
ggazzo
approved these changes
Sep 21, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
OC-169
Even if the page was reopening, Livechat will inform unread messages
Issue(s)
close #25529
Steps to test or reproduce
Further comments