Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Old rooms without the associated unit will not be displayed on the current chats #26685

Merged
merged 22 commits into from
Sep 22, 2022

Conversation

murtaza98
Copy link
Contributor

@murtaza98 murtaza98 commented Aug 25, 2022

Proposed changes (including videos or screenshots)

Issue(s)

Jira: OC-180

Steps to test or reproduce

Further comments

Todo's (Possible Engineering day items):

  • Migrate "UnitEdit" component on UI to use endpoint instead of "livechat:saveUnit" meteor method
  • Create a new model for "LivechatUnitMonitors" with updated types
    • remove unwanted field "monitor.username" (since we're already storing userId)

@murtaza98 murtaza98 marked this pull request as draft August 25, 2022 15:41
@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #26685 (dcf3d4a) into develop (5ed3271) will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26685      +/-   ##
===========================================
+ Coverage    40.67%   40.83%   +0.15%     
===========================================
  Files          793      793              
  Lines        17849    17849              
  Branches      1938     1938              
===========================================
+ Hits          7260     7288      +28     
+ Misses       10294    10263      -31     
- Partials       295      298       +3     
Flag Coverage Δ
e2e 40.83% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@murtaza98 murtaza98 changed the title [FIX] Units filter not working on current chats panel [FIX] Old rooms without the associated unit will not be displayed on the current chats Aug 29, 2022
@murtaza98 murtaza98 marked this pull request as ready for review August 29, 2022 15:00
@murtaza98 murtaza98 requested a review from a team as a code owner August 29, 2022 15:00
@murtaza98 murtaza98 requested a review from KevLehman August 30, 2022 06:59
@murtaza98 murtaza98 dismissed KevLehman’s stale review August 30, 2022 07:00

Changes done :)

@murtaza98 murtaza98 requested a review from a team as a code owner September 5, 2022 17:35
@murtaza98 murtaza98 requested a review from KevLehman September 5, 2022 17:39
@murtaza98 murtaza98 dismissed KevLehman’s stale review September 5, 2022 17:40

Changes done. Thanks :)

KevLehman
KevLehman previously approved these changes Sep 13, 2022
Copy link
Member

@KevLehman KevLehman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve it 👀 so we can start QAing, but let's wait on confirmation about stats collector b4 merging it

@murtaza98 murtaza98 added this to the 5.2.0 milestone Sep 14, 2022
ggazzo
ggazzo previously requested changes Sep 15, 2022
@ggazzo ggazzo added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Sep 16, 2022
@murtaza98 murtaza98 requested a review from ggazzo September 16, 2022 11:40
@murtaza98 murtaza98 dismissed ggazzo’s stale review September 16, 2022 11:41

Changes done :)

@murtaza98 murtaza98 requested a review from KevLehman September 16, 2022 11:41
@kodiakhq kodiakhq bot merged commit 1844151 into develop Sep 22, 2022
@kodiakhq kodiakhq bot deleted the current-chats-units-filter branch September 22, 2022 20:40
@tassoevan tassoevan mentioned this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad: omnichannel stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants