-
Notifications
You must be signed in to change notification settings - Fork 11.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMPROVE] System messages' consistency #26130
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #26130 +/- ##
===========================================
+ Coverage 40.54% 40.55% +0.01%
===========================================
Files 799 799
Lines 18296 18286 -10
Branches 1954 1954
===========================================
- Hits 7418 7416 -2
+ Misses 10583 10571 -12
- Partials 295 299 +4
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see a lot of translations where a variable has been removed, but the code is still providing them. For those cases I'd recommend creating a new string, because other languages will be incorrect anyways. The code also needs to be updated.
apps/meteor/app/channel-settings/server/functions/saveRoomType.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there, @LucianoPierdona could you please remove all font-styles from system-messages ? E.g: <em></em>
and etc...
There are a task to remove those, if you add will be confusing in some cases. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Let's wait for QA and we can merge.
Co-authored-by: Gleidson Daniel Silva <gleidson10daniel@hotmail.com>
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments