Voip outbound/outbound calling #25832
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description: This is an intial commit for device selection. Description for the changes is as follows: 1. Added new class DeviceManager for enumerating and managing devices. 2. Refactored Stream.ts. Stream management, track addition, removal is now managed thru Stream classes. 3. Added experimental components for verifying the code.
Description: This workspace deals with the fist commit and library changes for outbound calls. These changes create the necessary code for outbound calling. This workspace also establishes a rudimentary way to create a room for outbound call.
Description: Adding missing commits.
Description: Correctly setting the call state for outbound call.
Description: Media element was not getting set for remote stream, resulting in remote stream not being heard. Fixed it.
Description: Code cleanup
Description: Added changes for correctly handling system messages for outbound. Modified ContinuousMonitor to handle DialEnd event. This event is necessary to mark the success of outbound call. This event is used in omnichannel-voip/service.ts for sending the system message to a room.
Description: Fixing the room system message failures due to race condition.
Description: Managing Queue names while doing wrapup modal
Description: Fixing the issue with experimental test component
|
This pull request introduces 2 alerts when merging dd87090 into ca4c020 - view on LGTM.com new alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments