Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] VoIP Input/Output Device Selection #25966

Merged
merged 25 commits into from
Jun 28, 2022
Merged

Conversation

MartinSchoeler
Copy link
Contributor

@MartinSchoeler MartinSchoeler commented Jun 22, 2022

No description provided.

amolghode1981 and others added 3 commits June 21, 2022 14:57
* Clickup Task: https://app.clickup.com/t/22bmce2
Description: Creating EE structure for outbound dialing.
Refactored VoIPUser.ts and made necessary fields protected.
Created VoIPUser or EEVoipClient based on the licensing in SimpleVoipUser
Made necessary changes for using the voip client.

* Clickup Task: https://app.clickup.com/t/22bmce2
Description: Adding missing file.

* Clickup Task: https://app.clickup.com/t/22bmce2
Description: Connector changes for detecting the outbound call.

* Clickup Task: https://app.clickup.com/t/22bmce2
Description: Handling review comments.
Conflicts:
	apps/meteor/client/contexts/CallContext.ts
	apps/meteor/client/lib/voip/VoIPUser.ts
	apps/meteor/client/providers/CallProvider/CallProvider.tsx
	apps/meteor/client/providers/MeteorProvider.tsx
@MartinSchoeler MartinSchoeler requested a review from a team as a code owner June 22, 2022 20:32
@MartinSchoeler MartinSchoeler marked this pull request as draft June 22, 2022 20:49
@MartinSchoeler MartinSchoeler changed the base branch from new/voip-outbound to develop June 24, 2022 18:27
@MartinSchoeler MartinSchoeler marked this pull request as ready for review June 24, 2022 18:37
@MartinSchoeler MartinSchoeler requested a review from a team as a code owner June 24, 2022 18:37
sampaiodiego
sampaiodiego previously approved these changes Jun 24, 2022
@KevLehman KevLehman changed the title [NEW] Device Selection [NEW] VoIP Input/Output Device Selection Jun 27, 2022
@KevLehman KevLehman added this to the 5.0.0 milestone Jun 27, 2022
KevLehman
KevLehman previously approved these changes Jun 28, 2022
@KevLehman
Copy link
Contributor

This one, again, will be tested as part of full Outbound Calls feature

@ggazzo ggazzo added the stat: ready to merge PR tested and approved waiting for merge label Jun 28, 2022
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Jun 28, 2022

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

@kodiakhq kodiakhq bot removed the stat: ready to merge PR tested and approved waiting for merge label Jun 28, 2022
@ggazzo ggazzo added the stat: ready to merge PR tested and approved waiting for merge label Jun 28, 2022
KevLehman
KevLehman previously approved these changes Jun 28, 2022
@KevLehman KevLehman dismissed stale reviews from aleksandernsilva and themself via 12a0dc1 June 28, 2022 19:40
@kodiakhq kodiakhq bot merged commit bac49e2 into develop Jun 28, 2022
@kodiakhq kodiakhq bot deleted the new/device-selection branch June 28, 2022 21:25
gabriellsh added a commit that referenced this pull request Jun 29, 2022
…turbo

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [NEW] Community Edition Watermark (#25844)
  [BREAK] remove unused endpoints and restify others (#25889)
  Chore: add underscore to ddp-streamer
  [IMPROVE] VoIP admin page cleanup: remove unused settings (#25993)
  Regression: Fix micro services (#26054)
  Regression: Fix threads list (#26052)
  [NEW] VoIP Input/Output Device Selection (#25966)
  Chore: Account/Profile to TS (#25929)
gabriellsh added a commit that referenced this pull request Jun 29, 2022
…/clientPackage

* 'develop' of github.com:RocketChat/Rocket.Chat: (80 commits)
  [NEW] Community Edition Watermark (#25844)
  [BREAK] remove unused endpoints and restify others (#25889)
  Chore: add underscore to ddp-streamer
  [IMPROVE] VoIP admin page cleanup: remove unused settings (#25993)
  Regression: Fix micro services (#26054)
  Regression: Fix threads list (#26052)
  [NEW] VoIP Input/Output Device Selection (#25966)
  Chore: Account/Profile to TS (#25929)
  Chore: Add missing Swedish livechat translations (#26048)
  [IMPROVE] Expand the feature set of the new message rendering (#25970)
  Chore: Bump fuselage and update icon (#26036)
  [NEW][APPS] Allowing apps to register authenticated routes (#25937)
  [NEW] Enable outbound calling for EE (#25843) (#25960)
  Chore: Introduce new index to query active livechat conversations for cloud scaling (#26047)
  [FIX] Importer fails to download files from URLs with query string params (#25934)
  [IMPROVE] Moved call hold/unhold to EE (#26007)
  [NEW] Engagement Metrics - Phase 2 (#25505)
  Chore: Convert usePreventDefault, useQueryOptions, useShortcutOpenMenu (#26035)
  [FIX] Importer files are unnecessarily transferred over the network. (#25919)
  Chore: test turbo params (#26038)
  ...
@murtaza98 murtaza98 mentioned this pull request Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants