Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: convert autotranslate to ts #25953

Merged
merged 20 commits into from
Jul 22, 2022
Merged

Conversation

felipe-rod123
Copy link
Contributor

Proposed changes (including videos or screenshots)

Converted the apps/meteor/app/api/server/v1/autotranslate.js to ts and created endpoint typings on the packages/rest-typings/src/v1/autotranslate folder.

Issue(s)

Steps to test or reproduce

Further comments

@felipe-rod123 felipe-rod123 requested a review from a team as a code owner June 22, 2022 00:51
ggazzo
ggazzo previously approved these changes Jun 27, 2022
@github-actions github-actions bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jun 27, 2022
ggazzo
ggazzo previously approved these changes Jun 29, 2022
ggazzo
ggazzo previously approved these changes Jun 29, 2022
@CLAassistant
Copy link

CLAassistant commented Jul 22, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ felipe-rod123
✅ ggazzo
❌ kodiakhq[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

@kodiakhq kodiakhq bot merged commit 65c4906 into develop Jul 22, 2022
@kodiakhq kodiakhq bot deleted the chore/convert-autotranslate-to-ts branch July 22, 2022 05:02
gabriellsh added a commit that referenced this pull request Jul 26, 2022
* 'develop' of github.com:RocketChat/Rocket.Chat: (294 commits)
  Chore: Convert UserCardWithData to ts (#26192)
  Chore: cleanup startup of test and put wizard in setup function (#26306)
  Chore: Convert AccountPreferencesPage to ts (#26096)
  [FIX] Missing bio field UI validation (#26345)
  Chore: Remove square prop from IconButton (#26343)
  Chore: Rewrite VerticalBarOldActions to TS (#26277)
  Chore: Replace direct multiple icon (#26342)
  Chore: Upgrade ESLint (#26132)
  Chore: convert autotranslate to ts (#25953)
  Chore: Change some places still using fields to projection (#26308)
  Bump version to 5.1.0-develop
  Bump version to 5.0.0
  Bump version to 5.0.0-rc.12
  Regression: Livechat not rendering UiKit messages with action buttons (#26327)
  Chore: bump fuselage packages (#26325)
  Chore: Update useSidebarPalette selectors (#26322)
  Regression: Fix get myself user data (#26328)
  Bump version to 5.0.0-rc.11
  Bump version to 4.8.2
  Regression: fix `directory` endpoint not listing teams (#26310)
  ...
@murtaza98 murtaza98 mentioned this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants