-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW] Upload service #27543
Merged
Merged
[NEW] Upload service #27543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-gubert
requested review from
a team
and removed request for
thassiov and
d-gubert
December 14, 2022 19:51
Codecov Report
@@ Coverage Diff @@
## develop #27543 +/- ##
===========================================
+ Coverage 41.20% 42.02% +0.82%
===========================================
Files 845 818 -27
Lines 18291 17772 -519
Branches 2078 2003 -75
===========================================
- Hits 7536 7468 -68
+ Misses 10480 10034 -446
+ Partials 275 270 -5
Flags with carried forward coverage won't be shown. Click here to find out more. |
sampaiodiego
requested changes
Dec 15, 2022
dionisio-bot
bot
added
stat: ready to merge
PR tested and approved waiting for merge
and removed
stat: needs QA
labels
Dec 16, 2022
KevLehman
commented
Dec 16, 2022
sampaiodiego
approved these changes
Dec 19, 2022
gabriellsh
added a commit
that referenced
this pull request
Dec 20, 2022
…/attachment-file * 'develop' of github.com:RocketChat/Rocket.Chat: (33 commits) Chore: fix EmailInbox intermittent e2e tests (#27573) [IMPROVE] Authorize search of custom fields on `users.list` (#27423) Chore: Threads as React components (#27524) [NEW] Upload service (#27543) [FIX] Fix emoji appearance on sidebar (#27580) [FIX] RoomLeader status not working (#27576) [FIX] Announcement banner link opening in the same page (#27554) Bump version to 5.4.1 [FIX] Custom languages not being applied to i18next (#27557) [FIX] Registration and Login placeholders not being used (#27558) [FIX] Fix Login with Show default form disabled (#27475) [FIX] Message Actions menu does not close upon choosing an action (#27328) Chore: Deprecate unused omnichannel API (#27538) [FIX] Pagination not working on current chats (#27432) [FIX] Custom languages not being applied to i18next (#27557) [FIX] Registration and Login placeholders not being used (#27558) [FIX] Message Actions menu does not close upon choosing an action (#27328) Chore: Deprecate unused omnichannel API (#27538) Regression: Add button-icon-disabled-color to the palette (#27522) Chore: Refactor CreateChannelModal (#27469) ...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
This is taken from AppsEngine teamwork. Idea is to have this merged into develop faster as Omnichannel needs this same service :) and we don't want to fix conflicts