Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Upload service #27543

Merged
merged 5 commits into from
Dec 20, 2022
Merged

[NEW] Upload service #27543

merged 5 commits into from
Dec 20, 2022

Conversation

KevLehman
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

This is taken from AppsEngine teamwork. Idea is to have this merged into develop faster as Omnichannel needs this same service :) and we don't want to fix conflicts

@d-gubert d-gubert requested review from a team and removed request for thassiov and d-gubert December 14, 2022 19:51
@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

Merging #27543 (c6d5702) into develop (bef27c8) will increase coverage by 0.82%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27543      +/-   ##
===========================================
+ Coverage    41.20%   42.02%   +0.82%     
===========================================
  Files          845      818      -27     
  Lines        18291    17772     -519     
  Branches      2078     2003      -75     
===========================================
- Hits          7536     7468      -68     
+ Misses       10480    10034     -446     
+ Partials       275      270       -5     
Flag Coverage Δ
e2e 42.02% <ø> (+0.82%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@d-gubert d-gubert added this to the 6.0.0 milestone Dec 14, 2022
apps/meteor/server/services/upload/service.ts Outdated Show resolved Hide resolved
apps/meteor/server/services/upload/service.ts Outdated Show resolved Hide resolved
@KevLehman KevLehman requested review from a team and removed request for a team December 16, 2022 15:11
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Dec 16, 2022
@kodiakhq kodiakhq bot merged commit c71714a into develop Dec 20, 2022
@kodiakhq kodiakhq bot deleted the new/upload-service branch December 20, 2022 01:17
gabriellsh added a commit that referenced this pull request Dec 20, 2022
…/attachment-file

* 'develop' of github.com:RocketChat/Rocket.Chat: (33 commits)
  Chore: fix EmailInbox intermittent e2e tests (#27573)
  [IMPROVE] Authorize search of custom fields on `users.list` (#27423)
  Chore:  Threads as React components (#27524)
  [NEW] Upload service (#27543)
  [FIX] Fix emoji appearance on sidebar (#27580)
  [FIX] RoomLeader status not working (#27576)
  [FIX] Announcement banner link opening in the same page (#27554)
  Bump version to 5.4.1
  [FIX] Custom languages not being applied to i18next (#27557)
  [FIX] Registration and Login placeholders not being used (#27558)
  [FIX] Fix Login with Show default form disabled (#27475)
  [FIX] Message Actions menu does not close upon choosing an action (#27328)
  Chore: Deprecate unused omnichannel API (#27538)
  [FIX] Pagination not working on current chats (#27432)
  [FIX] Custom languages not being applied to i18next (#27557)
  [FIX] Registration and Login placeholders not being used (#27558)
  [FIX] Message Actions menu does not close upon choosing an action (#27328)
  Chore: Deprecate unused omnichannel API (#27538)
  Regression: Add button-icon-disabled-color to the palette (#27522)
  Chore: Refactor CreateChannelModal (#27469)
  ...
@sampaiodiego sampaiodiego mentioned this pull request Feb 17, 2023
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants